Skip to content

Migrate 5 effects to Graphics Example: Explosion, Mandelbrot, ShadeBobs, Twister, Wave#3204

Merged
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:migrate-5-effects
Apr 11, 2026
Merged

Migrate 5 effects to Graphics Example: Explosion, Mandelbrot, ShadeBobs, Twister, Wave#3204
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:migrate-5-effects

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 8, 2026

Summary

Migrates 5 more effects from SWT-OldSchoolEffect to the GraphicsExample framework.

Effects Migrated

  • ExplosionTab — Particle system with fire propagation algorithm
  • MandelbrotTab — Animated Mandelbrot fractal with continuous zoom
  • ShadeBobsTab — Heat trail shade bobs effect moving along a precomputed path
  • TwisterTab — Torsion deformation on a checkered pattern
  • WaveTab — Multiple wave motion patterns cycling through 4 algorithms

Checklist (per #3189)

  • No Color disposal (Colors not disposed — modern SWT)
  • Use simple new Color(r, g, b) constructor
  • Dispose Images (in dispose() and before recreation in paint())
  • Dispose GC (WaveTab disposes its offscreen GC)
  • No compiler errors or warnings — build succeeds
  • $NON-NLS-1$ markers on resource key strings
  • Proper EPL-2.0 copyright header with original author credit
  • Category = "Misc"
  • Localized strings in examples_graphics.properties
  • Inner classes for helpers (Particle in ExplosionTab)

Build Verification

mvn clean verify -Dnative=gtk.linux.x86_64 -DskipTestsBUILD SUCCESS

Fixes #3189

@vogella vogella marked this pull request as ready for review April 10, 2026 15:19
…bs, Twister, Wave

Migrate the following effects from SWT-OldSchoolEffect to GraphicsExample:
- ExplosionTab: Particle system with fire propagation
- MandelbrotTab: Animated Mandelbrot fractal with zoom
- ShadeBobsTab: Heat trail shade bobs effect
- TwisterTab: Torsion deformation on checkered pattern
- WaveTab: Multiple wave motion patterns

Each effect extends AnimatedGraphicsTab, is registered in
GraphicsExample.createTabs(), and has localized strings in
examples_graphics.properties.

Fixes eclipse-platform#3189

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vogella vogella force-pushed the migrate-5-effects branch from 5cf4777 to 02387c6 Compare April 10, 2026 15:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Test Results

  170 files  ±0    170 suites  ±0   26m 35s ⏱️ -37s
4 679 tests ±0  4 658 ✅ ±0   21 💤 ±0  0 ❌ ±0 
6 592 runs  ±0  6 437 ✅ ±0  155 💤 ±0  0 ❌ ±0 

Results for commit 02387c6. ± Comparison against base commit 16e501f.

♻️ This comment has been updated with latest results.

@vogella vogella merged commit fbe0d7a into eclipse-platform:master Apr 11, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate all SWT-OldSchoolEffect examples to GraphicsExample

1 participant