Skip to content

Remove fillRegion() and Region.subtract block in CTabFolderRenderer #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Apr 10, 2026
+1 −17
Merged

Remove fillRegion() and Region.subtract block in CTabFolderRenderer #3218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions ...ipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,13 +1209,6 @@ void drawTabArea(GC gc, Rectangle bounds, int state) {
boolean single = parent.single;
boolean bkSelected = single && selectedIndex != -1;
drawBackground(gc, shape, bkSelected);
// Fill in parent background for non-rectangular shape
Region r = new Region();
r.add(new Rectangle(x, y, width + 1, height + 1));
r.subtract(shape);
gc.setBackground(parent.getParent().getBackground());
fillRegion(gc, r);
r.dispose();

// Draw selected tab
if (selectedIndex == -1) {
Expand Down Expand Up @@ -1302,16 +1295,7 @@ void drawUnselected(int index, GC gc, Rectangle bounds, int state) {
}
}

void fillRegion(GC gc, Region region) {
// NOTE: region passed in to this function will be modified
Region clipping = new Region();
gc.getClipping(clipping);
region.intersect(clipping);
gc.setClipping(region);
gc.fillRectangle(region.getBounds());
gc.setClipping(clipping);
clipping.dispose();
}


Color getFillColor() {
if (fillColor == null) {
Expand Down
Loading