Skip to content

Add CTabFolder test coverage for untested API and edge cases#3222

Merged
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:feature/ctabfolder-test-coverage
Apr 11, 2026
Merged

Add CTabFolder test coverage for untested API and edge cases#3222
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:feature/ctabfolder-test-coverage

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 10, 2026

Summary

Tests added

  • Error handling: invalid arguments for setTabPosition and setTabHeight
  • Single mode: verifies only selected tab shows in single mode
  • Empty folder: operations on 0-item folder don't throw; state correct after disposing all items
  • Selection boundaries: out-of-range index is a silent no-op; empty folder returns null/-1
  • Min/max mutual exclusion: setMaximized(true) clears minimized state
  • Tab compression: tabs shrink when shell is resized smaller
  • SelectionListener contract: programmatic setSelection does NOT fire listener
  • Item disposal: disposing the currently selected item doesn't crash
  • showSelection: selected item is actually visible after call
  • Hit-testing: getItem(Point) returns correct item or null

Test plan

  • All 119 tests pass locally (0 failures, 0 errors)
  • CI passes on all platforms

🤖 Generated with Claude Code

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Test Results

  170 files  ± 0    170 suites  ±0   27m 22s ⏱️ +10s
4 692 tests +13  4 671 ✅ +13   21 💤 ±0  0 ❌ ±0 
6 670 runs  +78  6 515 ✅ +78  155 💤 ±0  0 ❌ ±0 

Results for commit c632c59. ± Comparison against base commit 16e501f.

♻️ This comment has been updated with latest results.

Adds 13 focused tests covering behavior that was previously untested:
error handling for invalid arguments, single-mode rendering, empty
folder edge cases, selection boundary conditions, min/max mutual
exclusion, tab compression under overflow, item disposal of the
selected item, hit-testing, and SelectionListener contract.

Contributes to eclipse-platform#3219

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vogella vogella force-pushed the feature/ctabfolder-test-coverage branch from 0209c0e to c632c59 Compare April 10, 2026 17:15
@vogella vogella marked this pull request as ready for review April 10, 2026 17:36
@vogella vogella merged commit 07605c9 into eclipse-platform:master Apr 11, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant