[Gtk4] Fix COLOR_LINK_FOREGROUND_RGBA value#3250
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts how SWT (GTK4) determines the system “link” foreground color so that COLOR_LINK_FOREGROUND_RGBA matches the theme’s actual link styling (notably in themes like HighContrast).
Changes:
- GTK4: use a temporary
GtkButtonand add the"link"CSS class before retrieving the link color. - GTK3: keep existing behavior using a temporary
GtkLabelto retrieve link color.
Use button (instead of link as is on gtk 3) and add "link" css class so correct color can be retrieved.
Contributor
jonahgraham
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use button (instead of link as is on gtk 3) and add "link" css class so correct color can be retrieved.