Skip to content

[Gtk4] Fix COLOR_LINK_FOREGROUND_RGBA value #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Apr 17, 2026
Merged

[Gtk4] Fix COLOR_LINK_FOREGROUND_RGBA value #3250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3299,36 +3299,36 @@ void initializeSystemColorsTitle(long shellContext) {
}

private void initializeSystemColorsLink() {
/*
* Note: GTK has two types of link at least:
*
* 1) GtkLabel with HTML-like markup
* 2) GtkLinkButton
*
* The 'HighContrast' theme has different colors for these.
* GtkLabel is easier to work with, and obtained color matches color in previous SWT versions.
*/

// The 'Clearlooks-Phenix' theme sets 'color:' for 'window {' css node, so a stand-alone label is not enough
long window;
if (GTK.GTK4) {
window = GTK4.gtk_window_new();
} else {
window = GTK3.gtk_window_new (GTK.GTK_WINDOW_TOPLEVEL);
}
long label = GTK.gtk_label_new(null);
if (GTK.GTK4) {
GTK4.gtk_window_set_child(window, label);
} else {
GTK3.gtk_container_add(window, label);
}
/*
* GTK 4 needs the "link" CSS class to retrieve the correct link color.
*/
long window = GTK4.gtk_window_new();
long button = GTK.gtk_button_new();
GTK4.gtk_window_set_child(window, button);
GTK.gtk_widget_add_css_class(button, Converter.wcsToMbcs("link", true));

long styleContextLink = GTK.gtk_widget_get_style_context (label);
COLOR_LINK_FOREGROUND_RGBA = styleContextGetColor (styleContextLink, GTK.GTK_STATE_FLAG_LINK);
long styleContextButton = GTK.gtk_widget_get_style_context(button);
COLOR_LINK_FOREGROUND_RGBA = styleContextGetColor(styleContextButton, GTK.GTK_STATE_FLAG_LINK);

if (GTK.GTK4) {
GTK4.gtk_window_destroy(window);
} else {
/*
* Note: GTK has two types of link at least:
*
* 1) GtkLabel with HTML-like markup
* 2) GtkLinkButton
*
* GtkLabel is easier to work with, and obtained color matches color in previous SWT versions.
*/
// The 'Clearlooks-Phenix' theme sets 'color:' for 'window {' css node, so a stand-alone label is not enough
long window = GTK3.gtk_window_new(GTK.GTK_WINDOW_TOPLEVEL);
long label = GTK.gtk_label_new(null);
GTK3.gtk_container_add(window, label);

long styleContextLink = GTK.gtk_widget_get_style_context(label);
COLOR_LINK_FOREGROUND_RGBA = styleContextGetColor(styleContextLink, GTK.GTK_STATE_FLAG_LINK);

GTK3.gtk_widget_destroy(window);
}
}
Expand Down
Loading