Make Shell.setSize() test compatible with fractional scaling#3267
Merged
HeikoKlare merged 1 commit intoApr 24, 2026
Merged
Conversation
The test case test_setSizeLorg_eclipse_swt_graphics_Point in Test_org_eclipse_swt_widgets_Shell sporadically fails in I-Builds and constantly fails when executed locally on a non-100% monitor. Due to rounding of the point-based size when converting to pixels upon setting the shell size, the value yielded by getSize() used for result validation is not necessarily equal. This change adapts the test case to apply an according tolerance value whenever the shell zoom is not 100%.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test case
test_setSizeLorg_eclipse_swt_graphics_PointinTest_org_eclipse_swt_widgets_Shellsporadically fails in I-Builds and constantly fails when executed locally on a non-100% monitor. Due to rounding of the point-based size when converting to pixels upon setting the shell size, the value yielded by getSize() used for result validation is not necessarily equal. This change adapts the test case to apply an according tolerance value whenever the shell zoom is not 100%.Supposed to fix this kind of failures sporadically seen in I-Build tests:
Similar to: