Skip to content

Make Shell.setSize() test compatible with fractional scaling #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Apr 24, 2026
Merged

Make Shell.setSize() test compatible with fractional scaling #3267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ...swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Shell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,20 +807,31 @@ public void test_setSizeLorg_eclipse_swt_graphics_Point() {
Point newSize = new Point(112, 27);
for (int i = 0; i < 10; i++) {
testShell.setSize(newSize);
assertEquals(newSize, testShell.getSize());
assertShellProperlySized(testShell, newSize);
newSize.x += 100;
newSize.y += 100;
}
newSize = new Point(1292, 1036);
for (int i = 0; i < 10; i++) {
testShell.setSize(newSize);
assertEquals(newSize, testShell.getSize());
assertShellProperlySized(testShell, newSize);
newSize.x -= 100;
newSize.y -= 100;
}
}
}

private void assertShellProperlySized(Shell shell, Point expectedSize) {
int tolerance = shell.getZoom() != 100 ? 1 : 0;
Point actualSize = shell.getSize();
assertTrue(
Math.abs(expectedSize.x - actualSize.x) <= tolerance
&& Math.abs(expectedSize.y - actualSize.y) <= tolerance,
"Shell is not sized correctly" //
+ " (expected size: " + expectedSize + " ± " + tolerance //
+ ", actual size: " + actualSize + ")");
}

Shell testShell;

private void createShell() {
Expand Down
Loading