Dim dirty tab bullet on inactive tabs in CTabFolderRenderer#3279
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom May 3, 2026
Merged
Conversation
The dirty indicator bullet inherited the tab text foreground color, which only varies between selected and unselected tabs in dark themes via CSS. In light themes the bullet looked identical on active and inactive tabs. Apply a reduced alpha (140) when drawing the bullet on unselected tabs so the active/inactive distinction works in any theme without CSS changes. Fixes eclipse-platform#3278
Contributor
Contributor
Author
@azoitl WDYT? |
|
@vogella I like it a lot. |
Contributor
Author
|
Happy that my suggestion was helpful 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dirty indicator bullet in CTabFolder previously inherited the tab text foreground color. That color only differs between selected and unselected tabs in dark themes via CSS, so in light themes the bullet looked identical on active and inactive tabs. Fixing this in CSS would also dim the tab title text, which is undesirable.
This change applies a reduced alpha (140, roughly 55%) when drawing the bullet on unselected tabs, so the active/inactive distinction shows up in any theme without configuration. The 3-arg drawClose overload is preserved for binary compatibility.
Fixes #3278