Add robust log level handling in JVSGLoggerLogManager#3287
Merged
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom May 7, 2026
Merged
Add robust log level handling in JVSGLoggerLogManager#3287HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
merks
reviewed
May 6, 2026
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Looks better. Just a tiny name consistency issue.
|
|
||
| import com.github.weisj.jsvg.logging.LogManager; | ||
| import com.github.weisj.jsvg.logging.Logger; | ||
| import com.github.weisj.jsvg.logging.Logger.Level; |
Contributor
There was a problem hiding this comment.
Maybe use the Logger.Level like the other parts to avoid this import? Or make the rest consistent?
Contributor
Author
There was a problem hiding this comment.
Yes, makes sense. Logger.Level is better to read than a generic Level, so I made the change consistent with how it was used alreday.
The JVSGLoggerLogManager allows to customize the log level with a system property. When an invalid log level is passed, the call currently throws an exception and makes the whole rasterizer initialization fail, leading to the non-availability of an SVG rasterizer throughout the whole application lifecycle. This change makes the system property processing more robust: when an invalid level is used, an error is printed and the implementation falls back to using "ERROR" as default log level. In addition, capitalization is ignored by always making the passed value upper case. As a result of this change, it not be possible to make the rasterizer implementation fail with an invalid system property anymore.
HeikoKlare
force-pushed
the
jsvglogger-level-config
branch
from
dee73cc to
4748451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JVSGLoggerLogManager allows to customize the log level with a system property. When an invalid log level is passed, the call currently throws an exception and makes the whole rasterizer initialization fail, leading to the non-availability of an SVG rasterizer throughout the whole application lifecycle.
This change makes the system property processing more robust: when an invalid level is used, an error is printed and the implementation falls back to using "ERROR" as default log level. In addition, capitalization is ignored by always making the passed value upper case. As a result of this change, it not be possible to make the rasterizer implementation fail with an invalid system property anymore.
Resolves #3283 (comment)