Drop dead log(Exception) helper in WorkbenchActivitySupport

The private log(Exception) method built an IStatus and discarded it, never
actually logging anything. It has been broken since it was introduced in
2004. The only caller swallows InvocationTargetException and
InterruptedException from ProgressMonitorDialog.run(); inline that swallow
with a comment explaining why the interrupt flag is not re-set
(ModalContext.run uses InterruptedException to signal cancellation, not
actual thread interruption).

Fixes #3915

Author: vogella

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/activities/ws/WorkbenchActivitySupport.java

@@ -21,7 +21,6 @@
 import org.eclipse.core.runtime.IExtensionPoint;
 import org.eclipse.core.runtime.IProduct;
 import org.eclipse.core.runtime.IProgressMonitor;
-import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Platform;
 import org.eclipse.core.runtime.dynamichelpers.ExtensionTracker;
 import org.eclipse.core.runtime.dynamichelpers.IExtensionChangeHandler;
@@ -55,7 +54,6 @@
 import org.eclipse.ui.internal.WorkbenchWindow;
 import org.eclipse.ui.internal.activities.MutableActivityManager;
 import org.eclipse.ui.internal.activities.ProxyActivityManager;
-import org.eclipse.ui.internal.misc.StatusUtil;
 import org.eclipse.ui.internal.registry.IWorkbenchRegistryConstants;
 
 /**
@@ -229,22 +227,15 @@ private void updateManager(final IContributionManager manager) {
 										try {
 											dialog.run(false, false, runnable);
 										} catch (InvocationTargetException | InterruptedException e2) {
-											log(e2);
+											// ModalContext.run uses InterruptedException to signal
+											// cancellation rather than actual thread interruption, so
+											// we do not re-set the interrupt flag here.
 										}
 									}));
 						}
 					}
 				}
 			}
-
-			/**
-			 * Logs an error message to the workbench log.
-			 *
-			 * @param e the exception to log
-			 */
-			private void log(Exception e) {
-				StatusUtil.newStatus(IStatus.ERROR, "Could not update contribution managers", e); //$NON-NLS-1$
-			}
 		});
 	}