Merge branch 'master' into master

Author: EdrilanBerisha

.github/workflows/copilot-setup-steps.yml

@@ -16,10 +16,10 @@ jobs:
       contents: read
     steps:
       - name: Checkout code
-        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
 
       - name: Set up JDK 21
-        uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
+        uses: actions/setup-java@ad2b38190b15e4d6bdf0c97fb4fca8412226d287 # v5.3.0
         with:
           java-version: '21'
           distribution: 'temurin'

AGENTS.md

@@ -61,19 +61,15 @@ Each bundle contains:
 - `src/` or `eclipseui/` - Java source code
 - `.settings/` - Eclipse compiler settings
 
-## Build System
-
-### Critical Limitation
 
+## Build System
 
-Use the `-Pbuild-individual-bundles` profile:
+### Building Individual Bundles
 
 ```bash
-# Compile single bundle
-mvn clean compile -pl :bundle-artifact-id -Pbuild-individual-bundles -q
-
-# Example for building a single bundle
-mvn clean verify -Pbuild-individual-bundles mvn clean verify -pl bundles/org.eclipse.ui -DskipTests
+# Compile single bundle such as org.eclipse.jface
+mvn clean compile -pl :org.eclipse.jface
+```
 
 ### Test Properties
 
@@ -82,40 +78,26 @@ From `pom.xml`:
 - `tycho.surefire.useUIThread=true` - Run tests on UI thread
 - `failOnJavadocErrors=true` - Fail build on Javadoc errors
 
-## Testing
-
 ### Running Tests
 
 **⚠️ IMPORTANT:** Use `mvn verify` (NOT `mvn test`) for Tycho projects. 
 Due to Maven Tycho lifecycle binding, tests run in the `integration-test` phase, not the `test` phase. Running `mvn test` will NOT execute tests.
 
 ```bash
 # Run tests for a specific test bundle from repository root
-mvn clean verify -pl :org.eclipse.ui.tests -Pbuild-individual-bundles
-
-# Run specific test class within a bundle
-mvn clean verify -pl :org.eclipse.ui.tests -Pbuild-individual-bundles -Dtest=StructuredViewerTest
+mvn clean verify -pl :org.eclipse.jface.tests
 
-# Skip tests during compilation
-mvn clean compile -Pbuild-individual-bundles -DskipTests
+# Run a specific test class within a bundle
+mvn clean verify -pl :org.eclipse.jface.tests -Dtest=ViewerTest
 ```
 
-**Finding test bundles:** Test bundles mirror production bundles:
-- Production: `bundles/org.eclipse.jface`
-- Tests: `tests/org.eclipse.jface.tests`
-
-### JUnit Guidelines
-
-- Prefer JUnit 5 (`org.junit.jupiter.api.*`) for new tests
-
-## Common Development Commands
+If classes under test have been modified, include both the changed source bundle and the test bundle in `-pl`:
+```bash
+mvn clean verify -pl :org.eclipse.jface,:org.eclipse.jface.tests
+```
 
-### Compilation
 
-
-# Compile and run tests
-mvn clean test -pl :bundle-artifact-id -Pbuild-individual-bundles
-```
+## Development Hints
 
 ### Finding Code
 
@@ -130,9 +112,14 @@ cat bundles/org.eclipse.jface/META-INF/MANIFEST.MF
 grep -r "pattern" bundles/org.eclipse.jface/src
 ```
 
-## Git Commits
+**Finding test bundles:** Test bundles mirror production bundles:
+- Production: `bundles/org.eclipse.jface`
+- Tests: `tests/org.eclipse.jface.tests`
+
+### JUnit Guidelines
+
+- Prefer JUnit 5 (`org.junit.jupiter.api.*`) for new tests
 
-**Do NOT add `Co-Authored-By` or similar AI attribution trailers to commits.** This fails the Eclipse license check.
 
 ## Critical Development Rules
 
@@ -205,9 +192,6 @@ output.. = bin/
 
 ## Troubleshooting
 
-### "Non-resolvable parent POM"
-Expected when running `mvn verify` at root. Use `-Pbuild-individual-bundles` for individual bundles.
-
 ### "Package does not exist"
 Check `META-INF/MANIFEST.MF` - add missing package to `Import-Package` or bundle to `Require-Bundle`.
 

bundles/org.eclipse.e4.ui.bindings/META-INF/MANIFEST.MF

@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.bindings;singleton:=true
-Bundle-Version: 0.15.100.qualifier
+Bundle-Version: 0.15.200.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin

bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/keys/KeyBindingDispatcher.java

@@ -304,7 +304,7 @@ public final boolean executeCommand(final ParameterizedCommand parameterizedComm
 		Object obj = HandlerServiceImpl.lookUpHandler(context, command.getId());
 		if (obj != null) {
 			if (obj instanceof IHandler handler) {
-				commandHandled = command.isEnabled() && handler.isHandled();
+				commandHandled = handler.isHandled();
 			} else {
 				commandHandled = true;
 			}
@@ -319,12 +319,12 @@ public final boolean executeCommand(final ParameterizedCommand parameterizedComm
 			getDisplay()
 					.asyncExec(() -> handleCommandExecution(parameterizedCommand, handlerService, trigger, obj));
 		} else {
-			handleCommandExecution(parameterizedCommand, handlerService, trigger, obj);
+			commandHandled &= handleCommandExecution(parameterizedCommand, handlerService, trigger, obj);
 		}
 		return (commandDefined && commandHandled);
 	}
 
-	private void handleCommandExecution(final ParameterizedCommand parameterizedCommand,
+	private boolean handleCommandExecution(final ParameterizedCommand parameterizedCommand,
 			final EHandlerService handlerService, final Event trigger, Object handler) {
 		final IEclipseContext staticContext = createContext(trigger);
 		try {
@@ -360,6 +360,7 @@ private void handleCommandExecution(final ParameterizedCommand parameterizedComm
 						}
 					}
 				}
+				return false;
 			}
 		} finally {
 			staticContext.dispose();
@@ -371,6 +372,7 @@ private void handleCommandExecution(final ParameterizedCommand parameterizedComm
 		if (keyAssistDialog != null) {
 			keyAssistDialog.clearRememberedState();
 		}
+		return true;
 	}
 
 	private boolean isTracingEnabled() {

bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF

@@ -5,10 +5,8 @@ Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-Version: 0.14.800.qualifier
-Export-Package: org.eclipse.e4.ui.css.core;x-internal:=true,
- org.eclipse.e4.ui.css.core.css2;x-friends:="org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.css.jface",
+Export-Package: org.eclipse.e4.ui.css.core.css2;x-friends:="org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.css.jface",
  org.eclipse.e4.ui.css.core.dom;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.ui.views.properties.tabbed,org.eclipse.ui.forms",
- org.eclipse.e4.ui.css.core.dom.parsers;x-internal:=true,
  org.eclipse.e4.ui.css.core.dom.properties;
   x-friends:="org.eclipse.e4.ui.css.swt,
    org.eclipse.ui.workbench,
@@ -28,19 +26,16 @@ Export-Package: org.eclipse.e4.ui.css.core;x-internal:=true,
    org.eclipse.ui.forms",
  org.eclipse.e4.ui.css.core.exceptions;x-friends:="org.eclipse.e4.ui.css.swt",
  org.eclipse.e4.ui.css.core.impl.dom;x-internal:=true,
- org.eclipse.e4.ui.css.core.impl.dom.parsers;x-internal:=true,
  org.eclipse.e4.ui.css.core.impl.dom.properties;x-friends:="org.eclipse.e4.ui.css.swt",
  org.eclipse.e4.ui.css.core.impl.engine;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.workbench.swt",
- org.eclipse.e4.ui.css.core.impl.sac;x-internal:=true,
+ org.eclipse.e4.ui.css.core.impl.engine.selector;x-friends:="org.eclipse.e4.ui.tests.css.core",
+ org.eclipse.e4.ui.css.core.impl.parser;x-friends:="org.eclipse.e4.ui.tests.css.core",
  org.eclipse.e4.ui.css.core.resources;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.workbench.renderers.swt",
- org.eclipse.e4.ui.css.core.sac;x-internal:=true,
  org.eclipse.e4.ui.css.core.util.impl.resources;x-friends:="org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.workbench.swt",
  org.eclipse.e4.ui.css.core.util.resources;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.workbench.swt",
  org.eclipse.e4.ui.css.core.utils;x-friends:="org.eclipse.e4.ui.css.swt"
-Import-Package: org.w3c.css.sac;version="1.3.0",
- org.w3c.css.sac.helpers;version="1.3.0"
-Require-Bundle: org.apache.batik.css;bundle-version="[1.9.1,2.0.0)",
- org.eclipse.equinox.common;bundle-version="[3.5.0,4.0.0)",
+Import-Package: org.w3c.css.sac;version="1.3.0"
+Require-Bundle: org.eclipse.equinox.common;bundle-version="[3.5.0,4.0.0)",
  org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)"
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Automatic-Module-Name: org.eclipse.e4.ui.css.core

bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/SACConstants.java

@@ -93,11 +93,6 @@ public void setDefaultStyleDeclaration(String pseudoE,
 	 */
 	public void onStylesApplied(NodeList nodes);
 
-	/**
-	 * Return the {@link CSSExtendedProperties} of the native widget.
-	 */
-	public CSSExtendedProperties getStyle();
-
 	/**
 	 * Method called after the {@link CSSStylableElement} was linked to the
 	 * native widget. You can add UI listener into this method.

bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/CSSExtendedProperties.java

@@ -18,7 +18,6 @@
 import java.util.List;
 import java.util.Map;
 import org.eclipse.e4.ui.css.core.engine.CSSEngine;
-import org.eclipse.e4.ui.css.core.impl.dom.CSSExtendedPropertiesImpl;
 import org.w3c.dom.Attr;
 import org.w3c.dom.DOMException;
 import org.w3c.dom.Document;
@@ -43,8 +42,6 @@ public abstract class ElementAdapter implements Element, CSSStylableElement {
 
 	private final Map <String, CSSStyleDeclaration> defaultStyleDeclarationMap = new HashMap<>();
 
-	private CSSExtendedProperties style;
-
 	private List<String> staticPseudoInstances;
 
 	public ElementAdapter(Object nativeWidget, CSSEngine engine) {
@@ -377,14 +374,6 @@ protected Element getElement(Object widget) {
 		return engine.getElement(widget);
 	}
 
-	@Override
-	public CSSExtendedProperties getStyle() {
-		if (style == null) {
-			style = new CSSExtendedPropertiesImpl(nativeWidget, engine);
-		}
-		return style;
-	}
-
 	@Override
 	public String[] getStaticPseudoInstances() {
 		if (staticPseudoInstances == null) {

bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/CSSStylableElement.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2013 Angelo Zerr and others.
+ * Copyright (c) 2008, 2026 Angelo Zerr and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -13,8 +13,7 @@
  *******************************************************************************/
 package org.eclipse.e4.ui.css.core.dom;
 
-import org.w3c.css.sac.Selector;
-import org.w3c.css.sac.SelectorList;
+import org.eclipse.e4.ui.css.core.impl.engine.selector.Selectors;
 import org.w3c.dom.css.CSSRule;
 
 /**
@@ -28,7 +27,7 @@ public interface ExtendedCSSRule extends CSSRule {
 	public CSSPropertyList getCSSPropertyList();
 
 	/**
-	 * Return the list of {@link Selector} of this {@link CSSRule}.
+	 * Return the list of selectors of this {@link CSSRule}.
 	 */
-	public SelectorList getSelectorList();
+	public Selectors.SelectorList getSelectorList();
 }