Skip to content

Commit 3792903

Browse files
zelenyhlebHeikoKlare
authored andcommitted
Clean up some warnings in org.eclipse.ui.dialogs package
Cleaned up some warnings related to raw types in org.eclipse.ui.dialogs package Signed-off-by: Nikifor Fedorov <nikifor.fedorov@arsysop.ru>
1 parent 8a19145 commit 3792903

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/ContainerSelectionDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ protected Control createDialogArea(Composite parent) {
151151
@Override
152152
protected void okPressed() {
153153

154-
List chosenContainerPathList = new ArrayList();
154+
List<IPath> chosenContainerPathList = new ArrayList<>();
155155
IPath returnValue = group.getContainerFullPath();
156156
if (returnValue != null) {
157157
chosenContainerPathList.add(returnValue);

bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/ProjectLocationMoveDialog.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package org.eclipse.ui.dialogs;
1919

2020
import java.util.ArrayList;
21+
import java.util.List;
2122

2223
import org.eclipse.core.resources.IProject;
2324
import org.eclipse.jface.resource.JFaceColors;
@@ -138,7 +139,7 @@ private IProject getProject() {
138139
@Override
139140
protected void okPressed() {
140141

141-
ArrayList list = new ArrayList();
142+
List<String> list = new ArrayList<>();
142143
list.add(getProject().getName());
143144
list.add(locationArea.getProjectLocation());
144145
setResult(list);

bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/ResourceSelectionDialog.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
import java.util.ArrayList;
1717
import java.util.Iterator;
18+
import java.util.List;
1819

1920
import org.eclipse.core.resources.IContainer;
2021
import org.eclipse.core.resources.IResource;
@@ -93,7 +94,7 @@ public ResourceSelectionDialog(Shell parentShell, IAdaptable rootElement, String
9394
* portion of this dialog's resource selection viewer.
9495
*/
9596
private void checkInitialSelections() {
96-
Iterator itemsToCheck = getInitialElementSelections().iterator();
97+
Iterator<?> itemsToCheck = getInitialElementSelections().iterator();
9798

9899
while (itemsToCheck.hasNext()) {
99100
IResource currentElement = (IResource) itemsToCheck.next();
@@ -132,7 +133,7 @@ protected Control createDialogArea(Composite parent) {
132133

133134
// create the input element, which has the root resource
134135
// as its only child
135-
ArrayList input = new ArrayList();
136+
List<IAdaptable> input = new ArrayList<>();
136137
input.add(root);
137138

138139
createMessageArea(composite);
@@ -183,7 +184,7 @@ public Object[] getChildren(Object o) {
183184
}
184185

185186
// filter out the desired resource types
186-
ArrayList results = new ArrayList();
187+
List<IResource> results = new ArrayList<>();
187188
for (IResource member : members) {
188189
// And the test bits with the resource types to see if they are what we want
189190
if ((member.getType() & resourceType) > 0) {
@@ -194,7 +195,7 @@ public Object[] getChildren(Object o) {
194195
}
195196
// input element case
196197
if (o instanceof ArrayList) {
197-
return ((ArrayList) o).toArray();
198+
return ((ArrayList<?>) o).toArray();
198199
}
199200
return new Object[0];
200201
}
@@ -222,8 +223,8 @@ private void initializeDialog() {
222223
*/
223224
@Override
224225
protected void okPressed() {
225-
Iterator resultEnum = selectionGroup.getAllCheckedListItems();
226-
ArrayList list = new ArrayList();
226+
Iterator<?> resultEnum = selectionGroup.getAllCheckedListItems();
227+
List<Object> list = new ArrayList<>();
227228
while (resultEnum.hasNext()) {
228229
list.add(resultEnum.next());
229230
}

0 commit comments

Comments
 (0)