Skip to content

Commit 4e89c0c

Browse files
committed
Restore bounded wait in QuickAccessDialogTest to avoid bundle timeout
The wait for the dialog initialization in testPreviousChoicesAvailableForExtension used TIMEOUT * 1000, about 83 minutes. When the dialog initialization stalls (notably on macOS), this wait blocks far past the 1200s tycho-surefire budget for the whole org.eclipse.ui.tests bundle, so the test runtime is killed with SIGTERM (exit code 143) and no test results are reported for the bundle. Restoring the wait to TIMEOUT lets the test fail fast and locally instead of hanging and taking down the entire bundle. See #4009
1 parent e314e02 commit 4e89c0c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/quickaccess/QuickAccessDialogTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ public void testPreviousChoicesAvailableForExtension() {
321321
* wait for the dialog initialization, to avoid race conditions later on in the test, see:
322322
* https://github.com/eclipse-platform/eclipse.platform.ui/issues/4009
323323
*/
324-
assertTrue(DisplayHelper.waitForCondition(text.getDisplay(), TIMEOUT * 1000,
324+
assertTrue(DisplayHelper.waitForCondition(text.getDisplay(), TIMEOUT,
325325
() -> dialog.infoText != null),
326326
"Unexpected dialog info: " + dialog.infoText);
327327
text.setText(TestQuickAccessComputer.TEST_QUICK_ACCESS_PROPOSAL_LABEL);

0 commit comments

Comments
 (0)