Commit 4f9ee7a
committed
Wait for the expected item count in QuickAccessDialogTest.testShowAll
testShowAll toggled "show all" (and back) but waited only for the table
item count to differ from the previous count, while asserting a
direction: more items when showing all, fewer when limiting again. The
visible row count can shift by one as scroll bars appear and disappear
during layout, so the "differs" wait could return on that incidental
change and capture a count that was not yet the expanded (or limited)
one, failing the assertion intermittently on macOS.
Wait for the actual asserted condition instead (count greater than the
limited count when showing all, less than the full count when limiting),
so an incidental one-off change no longer ends the wait early.1 parent 675a1a3 commit 4f9ee7a
1 file changed
Lines changed: 2 additions & 2 deletions
File tree
- tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/quickaccess
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | | - | |
| 246 | + | |
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
| 253 | + | |
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| |||
0 commit comments