Commit 51efa85
committed
Skip forceActive in generic editor tests when shell is already active
UITestUtil.forceActive() has a documented one second floor, made up of
four waitForJobs() calls, see bug 417258#c27.
AbstratGenericEditorTest.setUp() called it on every test method, so all
45 tests in the bundle paid it.
Measured on a full CI run, org.eclipse.ui.genericeditor.tests takes
66.3s, and 58.5s of that (88%) is a flat per-test floor of about 1.25s
that is present in every one of its 14 test classes.
Only force the shell active when it is not already the active shell,
which is the same condition forceActive() itself returns.1 parent b968217 commit 51efa85
1 file changed
Lines changed: 7 additions & 1 deletion
File tree
- tests/org.eclipse.ui.genericeditor.tests/src/org/eclipse/ui/genericeditor/tests
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
65 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
| |||
0 commit comments