Commit 55391d7
committed
Merge AbstractCSSEngine into CSSEngineImpl
The CSS core engine had two stacked abstract classes with no concrete
core implementation: AbstractCSSEngine (1,113 LOC) and a tiny
CSSEngineImpl (95 LOC) that only added parser-factory wiring,
property-handler registration helpers, and the boolean value
converter. Inline the small subclass into the base, keep the name
CSSEngineImpl since that is the type SWT engine subclasses and tests
already reference, and make makeCSSParser concrete (it was abstract
solely so CSSEngineImpl could supply its single implementation).
The class remains abstract because the CSSEngine.reapply() method has
no sensible default in the core bundle.
Update ParserTestUtil's parseCssWithoutImports cast and rename
AbstractCSSEngineTest to CSSEngineImplTest in the same pass to keep
test class names aligned with production class names. The test's
anonymous subclass no longer needs to override makeCSSParser since it
is now concrete on the base.
All bundles internal (x-friends only); no API surface changed.
Contributes to #39801 parent 8ad0c90 commit 55391d7
5 files changed
Lines changed: 1102 additions & 1153 deletions
File tree
- bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine
- tests/org.eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui
- css/core/impl/engine
- tests/css/core
- util
0 commit comments