Skip to content

Commit 69d1f6a

Browse files
committed
Add more tracing to QuickAccessContents
This change adds tracing to more async computations done in QuickAccessContents, to better understand what is missing during QuickAccessDialogTest fails in I-builds. See: #4009
1 parent a6ec55b commit 69d1f6a

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/quickaccess/QuickAccessContents.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,9 @@ public void updateProposals(String filter) {
165165
final Job currentComputeEntriesJob = Job.create(computingMessage, theMonitor -> {
166166
entries.set(
167167
computeMatchingEntries(filter, perfectMatch, maxNumberOfItemsInTable, theMonitor));
168+
Tracing.printTrace(QuickAccessContents.class.getName(),
169+
"[" + Thread.currentThread() + "] Computed entries: " + //$NON-NLS-1$ //$NON-NLS-2$
170+
Stream.of(entries.get()).flatMap(List::stream).map(e -> e.element.getId()).toList());
168171
return theMonitor.isCanceled() ? Status.CANCEL_STATUS : Status.OK_STATUS;
169172
});
170173
currentComputeEntriesJob.setPriority(Job.INTERACTIVE);
@@ -183,12 +186,14 @@ public IStatus runInUIThread(IProgressMonitor monitor) {
183186
currentComputeEntriesJob.addJobChangeListener(new JobChangeAdapter() {
184187
@Override
185188
public void done(IJobChangeEvent event) {
189+
Tracing.printTrace(QuickAccessContents.class.getName(),
190+
"[" + Thread.currentThread() + "] Compute entries Job result: " + event.getResult()); //$NON-NLS-1$ //$NON-NLS-2$
186191
computingFeedbackJob.cancel();
187192
if (computeProposalsJob == currentComputeEntriesJob && event.getResult().isOK()
188193
&& !table.isDisposed()) {
189194
if (Policy.DEBUG_QUICK_ACCESS) {
190195
Tracing.printTrace(QuickAccessContents.class.getName(),
191-
"[" + Thread.currentThread().getName() + "] Setting quick access contents: " + //$NON-NLS-1$ //$NON-NLS-2$
196+
"[" + Thread.currentThread() + "] Setting quick access contents: " + //$NON-NLS-1$ //$NON-NLS-2$
192197
Stream.of(entries.get()).flatMap(List::stream).map(e -> e.element.getId())
193198
.toList());
194199
}

0 commit comments

Comments
 (0)