Merge branch 'master' into 2739_edit_selectall

Author: deepika-u

.github/workflows/copilot-setup-steps.yml

@@ -16,7 +16,7 @@ jobs:
       contents: read
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
 
       - name: Set up JDK 21
         uses: actions/setup-java@v5

.mvn/extensions.xml

@@ -3,6 +3,6 @@
 	<extension>
 		<groupId>org.eclipse.tycho</groupId>
 		<artifactId>tycho-build</artifactId>
-		<version>4.0.12</version>
+		<version>5.0.1</version>
 	</extension>
 </extensions>

AGENTS.md

@@ -1,10 +1,11 @@
 # AGENTS.md
 
-This file provides guidance to AI Agents (claude-code, codex, gemini cli, ...) when working with code in this repository.
+This file provides guidance to AI Agents.
 
 ## Repository Overview
 
-Eclipse Platform UI provides the UI building blocks for Eclipse IDE and Eclipse Rich Client Platform (RCP). This includes JFace, workbench, commands framework, data binding, dialogs, editors, views, perspectives, and more. Built on top of SWT (Eclipse Standard Widget Toolkit).
+Eclipse Platform UI provides the building blocks for Eclipse IDE and Eclipse Rich Client Platform (RCP). 
+This includes JFace, workbench, commands framework, data binding, dialogs, editors, views, perspectives, and more. Built on top of SWT (Eclipse Standard Widget Toolkit).
 
 **Key Facts:**
 - **Language:** Java 21
@@ -64,27 +65,15 @@ Each bundle contains:
 
 ### Critical Limitation
 
+
 Use the `-Pbuild-individual-bundles` profile:
 
 ```bash
-# Compile a single bundle
-cd bundles/org.eclipse.jface
-mvn clean compile -Pbuild-individual-bundles
-
-# Run tests for a single bundle
-cd tests/org.eclipse.jface.tests
-mvn clean verify -Pbuild-individual-bundles
-
-# Run specific test class
-mvn test -Pbuild-individual-bundles -Dtest=ViewerTestClass
-```
-
-### Maven Configuration
+# Compile single bundle
+mvn clean compile -pl :bundle-artifact-id -Pbuild-individual-bundles -q
 
-Default config in `.mvn/maven.config`:
-- `-Pbuild-individual-bundles` - Enable individual bundle builds
-- `-Dtycho.target.eager=true` - Eager target resolution
-- `-Dtycho.localArtifacts=ignore` - Ignore local artifacts
+# Example for building a single bundle
+mvn clean verify -Pbuild-individual-bundles mvn clean verify -pl bundles/org.eclipse.ui -DskipTests
 
 ### Test Properties
 
@@ -97,22 +86,15 @@ From `pom.xml`:
 
 ### Running Tests
 
-**⚠️ IMPORTANT:** Use `mvn verify` (NOT `mvn test`) for Tycho projects. Due to Maven Tycho lifecycle binding, tests run in the `integration-test` phase, not the `test` phase. Running `mvn test` will NOT execute tests.
+**⚠️ IMPORTANT:** Use `mvn verify` (NOT `mvn test`) for Tycho projects. 
+Due to Maven Tycho lifecycle binding, tests run in the `integration-test` phase, not the `test` phase. Running `mvn test` will NOT execute tests.
 
 ```bash
-# Run all tests in a specific test bundle
-cd tests/org.eclipse.jface.tests
-mvn clean verify -Pbuild-individual-bundles
-
-# Run without clean (faster if no changes to dependencies)
-mvn verify -Pbuild-individual-bundles
-
 # Run tests for a specific test bundle from repository root
-mvn clean verify -pl :org.eclipse.jface.tests -Pbuild-individual-bundles
+mvn clean verify -pl :org.eclipse.ui.tests -Pbuild-individual-bundles
 
 # Run specific test class within a bundle
-cd tests/org.eclipse.jface.tests
-mvn clean verify -Pbuild-individual-bundles -Dtest=StructuredViewerTest
+mvn clean verify -pl :org.eclipse.ui.tests -Pbuild-individual-bundles -Dtest=StructuredViewerTest
 
 # Skip tests during compilation
 mvn clean compile -Pbuild-individual-bundles -DskipTests
@@ -125,40 +107,11 @@ mvn clean compile -Pbuild-individual-bundles -DskipTests
 ### JUnit Guidelines
 
 - Prefer JUnit 5 (`org.junit.jupiter.api.*`) for new tests
-- Use `@BeforeEach`/`@AfterEach` instead of `@Before`/`@After`
-- Use `@Disabled` instead of `@Ignore`
-- Use `Assertions.*` instead of `Assert.*`
-- JUnit 3 usage is limited to compatibility helpers (e.g., `org.eclipse.ui.tests.harness`)
-
-**Common test pattern:**
-```java
-@BeforeEach
-public void setUp() {
-    fDisplay = Display.getDefault();
-    fShell = new Shell(fDisplay);
-}
-
-@AfterEach
-public void tearDown() {
-    if (fShell != null) {
-        fShell.dispose();
-    }
-}
-
-@Test
-public void testSomething() {
-    // Test implementation
-    Assertions.assertEquals(expected, actual);
-}
-```
 
 ## Common Development Commands
 
 ### Compilation
 
-```bash
-# Compile single bundle
-mvn clean compile -pl :bundle-artifact-id -Pbuild-individual-bundles -q
 
 # Compile and run tests
 mvn clean test -pl :bundle-artifact-id -Pbuild-individual-bundles
@@ -192,29 +145,7 @@ Import-Package: org.osgi.service.event
 
 ### 2. SWT Resource Disposal
 
-**Must dispose SWT resources** (except system colors/fonts):
-
-```java
-// CORRECT - dispose in finally
-Shell shell = new Shell();
-try {
-    // use shell
-} finally {
-    shell.dispose();
-}
-
-// CORRECT - dispose custom colors/fonts/images
-Color color = new Color(display, 255, 0, 0);
-try {
-    // use color
-} finally {
-    color.dispose();
-}
-
-// INCORRECT - system resources don't need disposal
-Color systemColor = display.getSystemColor(SWT.COLOR_RED);
-// No dispose needed
-```
+**Must dispose SWT resources** (except colors and system fonts):
 
 ### 3. UI Thread Requirements
 
@@ -226,11 +157,6 @@ Display.getDefault().asyncExec(() -> {
     label.setText("Updated");
 });
 
-// Run synchronously (blocks until complete)
-Display.getDefault().syncExec(() -> {
-    button.setEnabled(false);
-});
-
 // Check if on UI thread
 if (Display.getCurrent() != null) {
     // Already on UI thread
@@ -266,47 +192,6 @@ source.. = src/
 output.. = bin/
 ```
 
-## Common Patterns
-
-### Data Binding
-
-```java
-DataBindingContext ctx = new DataBindingContext();
-
-// Bind widget to model
-ctx.bindValue(
-    WidgetProperties.text(SWT.Modify).observe(textWidget),
-    BeanProperties.value("propertyName").observe(model)
-);
-
-// Dispose when done
-ctx.dispose();
-```
-
-### JFace Viewers
-
-```java
-TableViewer viewer = new TableViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL);
-viewer.setContentProvider(ArrayContentProvider.getInstance());
-viewer.setLabelProvider(new LabelProvider() {
-    @Override
-    public String getText(Object element) {
-        return element.toString();
-    }
-});
-viewer.setInput(myList);
-```
-
-### Eclipse Commands
-
-Commands are defined in `plugin.xml` and handled via handlers:
-
-```java
-@Execute
-public void execute(IEclipseContext context) {
-    // Command implementation
-}
-```
 
 ## CI/GitHub Workflows
 

bundles/org.eclipse.e4.ui.bindings/.classpath

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
 	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
 	<classpathentry kind="src" path="src"/>
 	<classpathentry kind="output" path="bin"/>

bundles/org.eclipse.e4.ui.bindings/.settings/org.eclipse.jdt.core.prefs

@@ -24,9 +24,9 @@ org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nul
 org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.methodParameters=do not generate
-org.eclipse.jdt.core.compiler.codegen.targetPlatform=17
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=21
 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
-org.eclipse.jdt.core.compiler.compliance=17
+org.eclipse.jdt.core.compiler.compliance=21
 org.eclipse.jdt.core.compiler.debug.lineNumber=generate
 org.eclipse.jdt.core.compiler.debug.localVariable=generate
 org.eclipse.jdt.core.compiler.debug.sourceFile=generate
@@ -132,7 +132,7 @@ org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore
 org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
 org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
 org.eclipse.jdt.core.compiler.release=enabled
-org.eclipse.jdt.core.compiler.source=17
+org.eclipse.jdt.core.compiler.source=21
 org.eclipse.jdt.core.formatter.align_fields_grouping_blank_lines=2147483647
 org.eclipse.jdt.core.formatter.align_type_members_on_columns=false
 org.eclipse.jdt.core.formatter.alignment_for_additive_operator=16

bundles/org.eclipse.e4.ui.bindings/META-INF/MANIFEST.MF

@@ -1,11 +1,11 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.bindings;singleton:=true
-Bundle-Version: 0.14.800.qualifier
+Bundle-Version: 0.15.0.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-Bundle-RequiredExecutionEnvironment: JavaSE-17
+Bundle-RequiredExecutionEnvironment: JavaSE-21
 Bundle-ActivationPolicy: lazy
 Import-Package: jakarta.annotation;version="[2.1.0,3.0.0)",
  jakarta.inject;version="[2.0.0,3.0.0)",
@@ -16,7 +16,7 @@ Import-Package: jakarta.annotation;version="[2.1.0,3.0.0)",
  org.eclipse.jface.bindings.keys,
  org.eclipse.jface.dialogs,
  org.eclipse.jface.window
-Require-Bundle: org.eclipse.swt;bundle-version="[3.6.0,4.0.0)",
+Require-Bundle: org.eclipse.swt;bundle-version="[3.133.0,4.0.0)",
  org.eclipse.core.commands;bundle-version="[3.5.0,4.0.0)",
  org.eclipse.e4.core.contexts;bundle-version="1.0.0",
  org.eclipse.e4.core.di;bundle-version="1.1.0",

bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/sac/CSSDocumentHandlerImpl.java

@@ -91,7 +91,6 @@ public void ignorableAtRule(String atRule) throws CSSException {
 		if (!getNodeStack().empty()) {
 			((CSSRuleListImpl) getNodeStack().peek()).add(ir);
 		} else {
-			// _getNodeStack().push(ir);
 			nodeRoot = ir;
 		}
 	}
@@ -100,10 +99,6 @@ public void ignorableAtRule(String atRule) throws CSSException {
 	public void namespaceDeclaration(String prefix, String uri)
 			throws CSSException {
 		//TODO replace with eclipse logging
-		//		if (logger.isDebugEnabled()) {
-		//			logger.debug("Declare namespace [prefix=" + prefix + ", uri=" + uri
-		//					+ "]");
-		//		}
 	}
 
 	@Override
@@ -116,7 +111,6 @@ public void importStyle(String uri, SACMediaList media,
 		if (!getNodeStack().empty()) {
 			((CSSRuleListImpl) getNodeStack().peek()).add(ir);
 		} else {
-			// _getNodeStack().push(ir);
 			nodeRoot = ir;
 		}
 	}
@@ -125,27 +119,12 @@ public void importStyle(String uri, SACMediaList media,
 	public void startMedia(SACMediaList media) throws CSSException {
 
 		ignore = true;
-		//		// Create the media rule and add it to the rule list
-		//		CSSMediaRuleImpl mr = new CSSMediaRuleImpl(parentStyleSheet, null,
-		//				new MediaListImpl(media));
-		//		if (!getNodeStack().empty()) {
-		//			((CSSRuleListImpl) getNodeStack().peek()).add(mr);
-		//		}
-		//
-		//		// Create the rule list
-		//		CSSRuleListImpl rules = new CSSRuleListImpl();
-		//		mr.setRuleList(rules);
-		//		getNodeStack().push(mr);
-		//		getNodeStack().push(rules);
 	}
 
 	@Override
 	public void endMedia(SACMediaList media) throws CSSException {
 
 		ignore = false;
-		//		// Pop the rule list and media rule nodes
-		//		getNodeStack().pop();
-		//		nodeRoot = getNodeStack().pop();
 	}
 
 	@Override
@@ -176,26 +155,11 @@ public void endPage(String name, String pseudo_page) throws CSSException {
 	@Override
 	public void startFontFace() throws CSSException {
 		ignore = true;
-		//		// Create the font face rule and add it to the rule list
-		//		CSSFontFaceRuleImpl fontFaceRule = new CSSFontFaceRuleImpl(
-		//				parentStyleSheet, null);
-		//		if (!getNodeStack().empty()) {
-		//			((CSSRuleListImpl) getNodeStack().peek()).add(fontFaceRule);
-		//		}
-		//
-		//		// Create the style declaration
-		//		CSSStyleDeclarationImpl decl = new CSSStyleDeclarationImpl(fontFaceRule);
-		//		fontFaceRule.setStyle(decl);
-		//		getNodeStack().push(fontFaceRule);
-		//		getNodeStack().push(decl);
 	}
 
 	@Override
 	public void endFontFace() throws CSSException {
 		ignore = false;
-		//		// Pop both the style declaration and the font face rule nodes
-		//		getNodeStack().pop();
-		//		nodeRoot = getNodeStack().pop();
 	}
 
 	@Override

bundles/org.eclipse.e4.ui.css.swt.theme/.classpath

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
 	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
 	<classpathentry kind="src" path="src"/>
 	<classpathentry kind="output" path="bin"/>

bundles/org.eclipse.e4.ui.css.swt.theme/.settings/org.eclipse.jdt.core.prefs

@@ -7,9 +7,9 @@ org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nul
 org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.methodParameters=do not generate
-org.eclipse.jdt.core.compiler.codegen.targetPlatform=17
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=21
 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
-org.eclipse.jdt.core.compiler.compliance=17
+org.eclipse.jdt.core.compiler.compliance=21
 org.eclipse.jdt.core.compiler.debug.lineNumber=generate
 org.eclipse.jdt.core.compiler.debug.localVariable=generate
 org.eclipse.jdt.core.compiler.debug.sourceFile=generate
@@ -101,7 +101,7 @@ org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore
 org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
 org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
 org.eclipse.jdt.core.compiler.release=enabled
-org.eclipse.jdt.core.compiler.source=17
+org.eclipse.jdt.core.compiler.source=21
 org.eclipse.jdt.core.formatter.align_fields_grouping_blank_lines=2147483647
 org.eclipse.jdt.core.formatter.align_type_members_on_columns=false
 org.eclipse.jdt.core.formatter.alignment_for_additive_operator=16