Update Color constructors to modern signature

Follows eclipse-platform/eclipse.platform.swt#3232
by removing the Device/Display argument from Color constructors.

Author: vogella

bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/helpers/CSSSWTColorHelper.java

@@ -52,7 +52,7 @@ public class CSSSWTColorHelper {
 
 	/*--------------- SWT Color Helper -----------------*/
 
-	public static Color getSWTColor(RGBColor rgbColor, Display display) {
+	public static Color getSWTColor(RGBColor rgbColor) {
 		RGBA rgb = getRGBA(rgbColor);
 		return new Color(rgb);
 	}

bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ColorRegistry.java

@@ -124,7 +124,7 @@ public ColorRegistry(Display display, boolean cleanOnDisplayDisposal) {
 	}
 
 	/**
-	 * Create a new <code>Color</code> on the receivers <code>Display</code>.
+	 * Create a new <code>Color</code> for the given RGB value.
 	 *
 	 * @param rgb the <code>RGB</code> data for the color.
 	 * @return the new <code>Color</code> object.

bundles/org.eclipse.jface/src/org/eclipse/jface/resource/RGBColorDescriptor.java

@@ -66,10 +66,8 @@ public int hashCode() {
 
 	@Override
 	public Color createColor(Device device) {
-		// If this descriptor is wrapping an existing color, then we can return the original color
-		// if this is the same device.
-		if (originalColor != null && originalColor.getDevice() == device) {
-			// If we're allocating on the same device as the original color, return the original.
+		// If this descriptor is wrapping an existing color, return the original.
+		if (originalColor != null) {
 			return originalColor;
 		}
 		return new Color(color);

bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java

@@ -4222,8 +4222,6 @@ private void initializeFindScopeColor(ISourceViewer viewer) {
 		IPreferenceStore store = getPreferenceStore();
 		if (store != null) {
 
-			StyledText styledText = viewer.getTextWidget();
-
 			Color color = createColor(store, PREFERENCE_COLOR_FIND_SCOPE);
 
 			IFindReplaceTarget target = viewer.getFindReplaceTarget();

examples/org.eclipse.jface.text.examples/src/org/eclipse/jface/text/examples/sources/inlined/InlinedAnnotationDemo.java

@@ -41,7 +41,6 @@
 import org.eclipse.jface.text.source.inlined.Positions;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.graphics.Color;
-import org.eclipse.swt.graphics.Device;
 import org.eclipse.swt.graphics.GC;
 import org.eclipse.swt.graphics.Rectangle;
 import org.eclipse.swt.layout.FillLayout;
@@ -195,7 +194,7 @@ private static Set<AbstractInlinedAnnotation> getInlinedAnnotation(ISourceViewer
 				String rgb = line.substring(index + "color:".length()).trim();
 				try {
 					String status = "OK!";
-					Color color = parse(rgb, viewer.getTextWidget().getDisplay());
+					Color color = parse(rgb);
 					if (color != null) {
 					} else {
 						status = "ERROR!";
@@ -282,7 +281,7 @@ private static int addRGBParamNameAnnotation(String paramName, String rgbContent
 	 *            the rgb string color
 	 * @return the created color and null otherwise.
 	 */
-	private static Color parse(String input, Device device) {
+	private static Color parse(String input) {
 		Pattern c = Pattern.compile("rgb *\\( *([0-9]+), *([0-9]+), *([0-9]+) *\\)");
 		Matcher m = c.matcher(input);
 		if (m.matches()) {