Commit 95b8d19
committed
Remove blind settle delay from code mining test fixtures
CodeMiningTest.setUp() and CodeMiningLineHeaderAnnotationTest.setUp()
both ended with DisplayHelper.sleep(display, 1000), placed directly
after a waitForCondition() that had already established that the text
widget is visible. DisplayHelper.sleep() is waitForCondition() with the
condition hardcoded to false, so it always burns the full second.
CodeMiningTest installs its provider on an empty document, and the
provider skips blank lines, so no code minings are produced during
setUp and there is nothing to settle for.
Measured on a full CI run, CodeMiningTest is 22.6s over 19 tests with a
median of 1.04s against a minimum of 0.19s, and
CodeMiningLineHeaderAnnotationTest is 4.0s over 4 tests with minimum
and median both 1.01s.1 parent 86e17df commit 95b8d19
2 files changed
Lines changed: 0 additions & 2 deletions
File tree
- tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | 73 | | |
75 | 74 | | |
76 | 75 | | |
| |||
tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
136 | 135 | | |
137 | 136 | | |
138 | 137 | | |
| |||
0 commit comments