Simplify duplicated workspace-lock error handling in IDEApplication

The "already set" branch of checkInstanceLocation repeated hideSplash and
the generic "cannot be set" error dialog across a nested if/else. Collapse
to a single splash hide and one error path; behavior is unchanged.

Author: vogella

bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java

@@ -277,27 +277,23 @@ protected Object checkInstanceLocation(Shell shell, Map applicationArguments) {
 					// 1. directory is already in use
 					// 2. directory could not be created
 					File workspaceDirectory = new File(instanceLoc.getURL().getFile());
-					if (workspaceDirectory.exists()) {
-						if (isDevLaunchMode(applicationArguments)) {
-							return EXIT_WORKSPACE_LOCKED;
-						}
+					boolean workspaceDirectoryExists = workspaceDirectory.exists();
 
-						// check if there is a lock info then append it to error message.
-						String lockInfo = WorkspaceLock.getWorkspaceLockDetails(instanceLoc.getURL());
-						if (lockInfo != null) {
-							hideSplash(shell);
-							WorkspaceLock.showWorkspaceLockedDialog(shell, workspaceDirectory.getAbsolutePath(),
-									lockInfo);
-						} else {
-							hideSplash(shell);
-							MessageDialog.openError(shell,
-									IDEWorkbenchMessages.IDEApplication_workspaceCannotBeSetTitle,
-									IDEWorkbenchMessages.IDEApplication_workspaceCannotBeSetMessage);
-						}
+					// In dev (PDE) launch mode let the launcher report the locked workspace.
+					if (workspaceDirectoryExists && isDevLaunchMode(applicationArguments)) {
+						return EXIT_WORKSPACE_LOCKED;
+					}
+
+					// If the directory exists and carries lock info, show it; otherwise
+					// report that the workspace location could not be set.
+					String lockInfo = workspaceDirectoryExists
+							? WorkspaceLock.getWorkspaceLockDetails(instanceLoc.getURL())
+							: null;
+					hideSplash(shell);
+					if (lockInfo != null) {
+						WorkspaceLock.showWorkspaceLockedDialog(shell, workspaceDirectory.getAbsolutePath(), lockInfo);
 					} else {
-						hideSplash(shell);
-						MessageDialog.openError(
-								shell,
+						MessageDialog.openError(shell,
 								IDEWorkbenchMessages.IDEApplication_workspaceCannotBeSetTitle,
 								IDEWorkbenchMessages.IDEApplication_workspaceCannotBeSetMessage);
 					}