Skip to content

Commit b268df2

Browse files
committed
Avoid running addons SWT tests twice in the Tycho build
The org.eclipse.e4.ui.workbench.addons.swt.test bundle defined an AllTests @suite while Tycho also scans test classes by name, so MaximizeBugTest, MaximizePartSashContainerPlaceholderTest and CleanupAddonTest each ran twice per build. For MaximizeBugTest that wasted about 35 seconds on every platform. Remove the redundant AllTests suite and rename MaximizableChildrenTag to MaximizableChildrenTagTest so the scanner runs it directly. Every test class now runs exactly once. The bundle has no test.xml, so the Ant nightly is not affected.
1 parent 4f9ee7a commit b268df2

2 files changed

Lines changed: 1 addition & 20 deletions

File tree

tests/org.eclipse.e4.ui.workbench.addons.swt.test/src/org/eclipse/e4/ui/workbench/addons/AllTests.java

Lines changed: 0 additions & 19 deletions
This file was deleted.

tests/org.eclipse.e4.ui.workbench.addons.swt.test/src/org/eclipse/e4/ui/workbench/addons/minmax/MaximizableChildrenTag.java renamed to tests/org.eclipse.e4.ui.workbench.addons.swt.test/src/org/eclipse/e4/ui/workbench/addons/minmax/MaximizableChildrenTagTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
import org.junit.jupiter.api.BeforeEach;
4646
import org.junit.jupiter.api.Test;
4747

48-
public class MaximizableChildrenTag {
48+
public class MaximizableChildrenTagTest {
4949

5050
private static final String MAXIMIZEABLE_CHILDREN = IPresentationEngine.MIN_MAXIMIZEABLE_CHILDREN_AREA_TAG;
5151
private Shell shell;

0 commit comments

Comments
 (0)