Capture long-operation time before workbench shutdown

Avoid calling PlatformUI.getWorkbench() from disconnectFromWorkspace(),
which runs from postShutdown() and may execute (via the workspace-locked
timerExec retry) after the workbench has been torn down. The display is
fetched via Display.getCurrent(), matching the existing pattern in
postShutdown(), and the long-operation time is captured in initialize().

Author: vogella

bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java

@@ -153,6 +153,13 @@ public class IDEWorkbenchAdvisor extends WorkbenchAdvisor {
 	 */
 	private final int workspaceWaitDelay;
 
+	/**
+	 * Captured during {@link #initialize(IWorkbenchConfigurer)} so
+	 * {@link #disconnectFromWorkspace()} does not have to reach through
+	 * {@link PlatformUI#getWorkbench()} after the workbench has been shut down.
+	 */
+	private int savedLongOperationTime;
+
 	private final Listener closeListener = event -> {
 		boolean doExit = IDEWorkbenchWindowAdvisor.promptOnExit(null);
 		event.doit = doExit;
@@ -191,6 +198,8 @@ public IDEWorkbenchAdvisor(DelayedEventsProcessor processor) {
 	@Override
 	public void initialize(IWorkbenchConfigurer configurer) {
 
+		savedLongOperationTime = configurer.getWorkbench().getProgressService().getLongOperationTime();
+
 		PluginActionBuilder.setAllowIdeLogging(true);
 
 		initResourceTracking();
@@ -487,8 +496,8 @@ protected void disconnectFromWorkspace() {
 			}
 		};
 
-		final Display display = PlatformUI.getWorkbench().getDisplay();
-		final int longOperationTime = PlatformUI.getWorkbench().getProgressService().getLongOperationTime();
+		final Display display = Display.getCurrent();
+		final int longOperationTime = savedLongOperationTime;
 		final Runnable openDialog = () -> {
 			if (ProgressManagerUtil.safeToOpen(dialog, null)) {
 				dialog.open();