Skip to content

Commit c6f391f

Browse files
committed
Remove redundant platform-specific dark theme processors
Display.setDarkThemePreferred(boolean) is a cross-platform SWT API that signals the OS dark mode preference, and the ThemeEngine already calls it whenever the CSS theme changes. The platform-specific dark theme processors, which toggle the same OS preference through internal, reflection-based hooks, are therefore redundant. Remove the dark theme processors: - org.eclipse.e4.ui.swt.gtk (DarkThemeProcessor using OS.setDarkThemePreferred) - org.eclipse.e4.ui.swt.win32 (DarkThemeProcessor using OS.setTheme) - org.eclipse.e4.ui.workbench.renderers.swt.cocoa (CocoaDarkThemeProcessor using OS.setTheme) The gtk and win32 fragments only existed to host these processors and are removed together with their entries in the org.eclipse.e4.rcp feature. The cocoa fragment is kept because it still provides other processors. The early display.setDarkThemePreferred(true) call and the manual styling of the workspace selection dialog in IDEApplication are left untouched, since the CSS engine is not yet running at that point in the startup sequence. Fixes #3857
1 parent d500209 commit c6f391f

35 files changed

Lines changed: 0 additions & 1400 deletions

bundles/org.eclipse.e4.ui.swt.gtk/.classpath

Lines changed: 0 additions & 11 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/.project

Lines changed: 0 additions & 51 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/.settings/org.eclipse.core.resources.prefs

Lines changed: 0 additions & 2 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/.settings/org.eclipse.jdt.core.prefs

Lines changed: 0 additions & 434 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/.settings/org.eclipse.jdt.ui.prefs

Lines changed: 0 additions & 3 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/.settings/org.eclipse.m2e.core.prefs

Lines changed: 0 additions & 4 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/.settings/org.eclipse.pde.prefs

Lines changed: 0 additions & 2 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/META-INF/MANIFEST.MF

Lines changed: 0 additions & 15 deletions
This file was deleted.

bundles/org.eclipse.e4.ui.swt.gtk/README.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)