Find/Replace overlay: adopt Eclipse command infrastructure

The overlay previously dispatched keyboard shortcuts through custom SWT
KeyListeners and toggled button enablement by manipulating ToolItems
directly, bypassing the Eclipse key binding framework entirely:
shortcuts
could not be seen or customized via Preferences > Keys, and user-defined
overrides were silently ignored.

FindReplaceOverlayAction now extends AbstractHandler, so every overlay
operation is a real Eclipse handler. AccessibleToolItem.setAction()
derives a ToolItem's enabled state and shortcut-hint tooltip from the
action itself (via IHandlerListener and a hint resolved through
IBindingService), instead of having them pushed to it explicitly at each
call site.

A dedicated key-binding context hierarchy, declared in plugin.xml and
activated/deactivated with overlay focus, scopes the search- and
replace-specific commands separately from the ones common to the whole
overlay:

  findReplaceOverlay (parent, active while the search or replace field
has focus)
  |- findReplaceOverlay.searchFocused (active while the search field has
focus)
  |- findReplaceOverlay.replaceFocused (active while the replace field
has focus)

Handler activation for the overlay's own commands is registered once per
action, scoped by an ACTIVE_FOCUS_CONTROL-based expression backed by
IFocusService tracking the search/replace text controls, rather than
imperatively activated and deactivated on every focus-gained/-lost
event.

Context activation/deactivation is made defensively idempotent rather
than
relying on focus-gained/-lost events always alternating strictly:
activating
a bar's context first clears any contexts still active from a previous
activation, and disposing the overlay's container control also
deactivates
any active contexts and reactivates the target editor's actions, since
disposal is not guaranteed to always be preceded by a focus-lost event.

Fixes
#2015
Prepares
#1912

Author: HeikoKlare

bundles/org.eclipse.ui.workbench.texteditor/plugin.properties

@@ -206,6 +206,21 @@ command.joinLines.name = Join Lines
 command.openHyperlink.name= Open Hyperlink
 command.openHyperlink.description= Opens the hyperlink at the caret location or opens a chooser if more than one hyperlink is available
 
+command.findReplaceOverlay.searchForward.name= Find and Replace: Search Forward
+command.findReplaceOverlay.searchBackward.name= Find and Replace: Search Backward
+command.findReplaceOverlay.selectAll.name= Find and Replace: Select All Matches
+command.findReplaceOverlay.replaceOne.name= Find and Replace: Replace
+command.findReplaceOverlay.replaceAll.name= Find and Replace: Replace All
+command.findReplaceOverlay.close.name= Find and Replace: Close
+command.findReplaceOverlay.toggleReplace.name= Find and Replace: Toggle Replace Bar
+command.findReplaceOverlay.toggleCaseSensitive.name= Find and Replace: Toggle Case Sensitive
+command.findReplaceOverlay.toggleWholeWord.name= Find and Replace: Toggle Whole Word
+command.findReplaceOverlay.toggleRegex.name= Find and Replace: Toggle Regular Expression
+command.findReplaceOverlay.toggleSearchInSelection.name= Find and Replace: Toggle Search in Selection
+context.findReplaceOverlay.name= Find and Replace
+context.findReplaceOverlay.searchFocused.name= Find and Replace (Search Input Focused)
+context.findReplaceOverlay.replaceFocused.name= Find and Replace (Replace Input Focused)
+
 Color.rangeIndicator= Range indicator color
 Color.rangeIndicatorDesc= The color that is used for the ruler that marks the range of the current selected text block.
 

bundles/org.eclipse.ui.workbench.texteditor/plugin.xml

@@ -507,6 +507,61 @@
             description="%command.openHyperlink.description"
             categoryId="org.eclipse.ui.category.textEditor"
             id="org.eclipse.ui.edit.text.open.hyperlink">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.searchForward.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchForward">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.searchBackward.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchBackward">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.selectAll.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.selectAll">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.replaceOne.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.replaceOne">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.replaceAll.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.replaceAll">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.close.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.close">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.toggleReplace.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleReplace">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.toggleCaseSensitive.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleCaseSensitive">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.toggleWholeWord.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleWholeWord">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.toggleRegex.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleRegex">
+      </command>
+      <command
+            name="%command.findReplaceOverlay.toggleSearchInSelection.name"
+            categoryId="org.eclipse.ui.category.textEditor"
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleSearchInSelection">
       </command>
 	</extension>
 
@@ -1500,4 +1555,82 @@
             label="%CodeMining.show.ZWSP">
       </codeMiningProvider>
    </extension>
+
+   <extension
+         point="org.eclipse.ui.contexts">
+      <context
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay"
+            name="%context.findReplaceOverlay.name"
+            parentId="org.eclipse.ui.textEditorScope">
+      </context>
+      <context
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchFocused"
+            name="%context.findReplaceOverlay.searchFocused.name"
+            parentId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay">
+      </context>
+      <context
+            id="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.replaceFocused"
+            name="%context.findReplaceOverlay.replaceFocused.name"
+            parentId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay">
+      </context>
+   </extension>
+
+   <extension
+         point="org.eclipse.ui.bindings">
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.close"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="ESC"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleReplace"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M1+R"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleCaseSensitive"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M1+M2+C"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleWholeWord"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M1+M2+D"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleRegex"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M1+M2+P"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.toggleSearchInSelection"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M1+M2+I"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchForward"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchFocused"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="CR"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchBackward"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchFocused"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M2+CR"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.selectAll"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.searchFocused"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M1+CR"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.replaceOne"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.replaceFocused"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="CR"/>
+      <key
+            commandId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.replaceAll"
+            contextId="org.eclipse.ui.workbench.texteditor.findReplaceOverlay.replaceFocused"
+            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"
+            sequence="M1+CR"/>
+   </extension>
 </plugin>