Skip to content

Commit db33b10

Browse files
trancexpressfedejeanne
authored andcommitted
Improve assertions in ListViewerRefreshTest.testNoSelectionRefresh
Fixes: #3798
1 parent 0fe0bd4 commit db33b10

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/viewers/ListViewerRefreshTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,15 @@ public void testNoSelectionRefresh() throws Exception {
8484
runEventLoop(shell.getDisplay(), DELAY);
8585

8686
run("Scrolled to position 30.", () -> viewer.reveal(input.get(30)));
87+
waitAndAssertCondition(shell.getDisplay(), () -> assertNotEquals(viewer.getList().getTopIndex(), 0,
88+
"Initial scroll to failed"));
8789

8890
run("Refreshed viewer without a selection.", viewer::refresh);
8991

9092
// BUG: The top index should not be the first item.
9193

92-
waitAndAssertCondition(shell.getDisplay(), () -> assertNotEquals(viewer.getList().getTopIndex(), 0));
94+
waitAndAssertCondition(shell.getDisplay(), () -> assertNotEquals(viewer.getList().getTopIndex(), 0,
95+
"Scroll to position not preserved after refresh"));
9396
}
9497

9598
/**

0 commit comments

Comments
 (0)