Skip to content

Commit e7c3a20

Browse files
committed
Remove OpenCloseTest from UiTestSuite
OpenCloseTest is a stress test that repeatedly opens and closes editors, views, perspectives, workbench windows and the intro part. On the macOS CI runners it is the single most expensive test (about 290s, roughly 29% of the whole org.eclipse.ui.tests suite) and it intermittently stalls in testOpenClosePerspective for 8 to 9 minutes, which kills the forked test VM through the per-bundle timeout. The watchdog added earlier only turns that stall into a fast failure; it removes neither the cost nor the flakiness. The open/close cycles it exercises are already covered functionally and for leaks elsewhere, for example LeakTests (testSimpleEditorLeak, testSimpleViewLeak, testSimpleWindowLeak), IWorkbenchPageTest, the zoom ShowView and OpenEditor tests and the intro tests. Removing it from the suite loses no real coverage while reclaiming a large, variable chunk of the macOS validation time. The test class is kept for manual stress testing. Fixes #4101
1 parent 80da000 commit e7c3a20

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

  • tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/UiTestSuite.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
import org.eclipse.ui.tests.releng.PluginActivationTests;
5555
import org.eclipse.ui.tests.services.ServicesTestSuite;
5656
import org.eclipse.ui.tests.statushandlers.StatusHandlingTestSuite;
57-
import org.eclipse.ui.tests.stress.OpenCloseTest;
5857
import org.eclipse.ui.tests.systeminplaceeditor.OpenSystemInPlaceEditorTest;
5958
import org.eclipse.ui.tests.themes.ThemesTestSuite;
6059
import org.eclipse.ui.tests.zoom.ZoomTestSuite;
@@ -108,7 +107,6 @@
108107
WorkbenchDatabindingTest.class,
109108
ChooseWorkspaceDialogTests.class,
110109
ViewerItemsLimitTest.class,
111-
OpenCloseTest.class,
112110
WorkspaceLockTest.class
113111
})
114112
public class UiTestSuite {

0 commit comments

Comments
 (0)