Find/replace overlay: remove obsolete setting of button states

Several button states are still explicitly state upon changes in the
logical find/replace state even though they are already updated via
observer mechanisms. This change removes the obsolete selection calls on
those buttons.

Author: HeikoKlare

bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java

@@ -543,7 +543,6 @@ private void createSearchTools() {
 				.withImage(FindReplaceOverlayImages.get(FindReplaceOverlayImages.KEY_FIND_NEXT))
 				.withToolTipText(FindReplaceMessages.FindReplaceOverlay_downSearchButton_toolTip)
 				.withAction(searchForwardAction).build();
-		searchForwardButton.setSelection(true); // by default, search down
 
 		FindReplaceOverlayAction selectAllAction = new FindReplaceOverlayAction(this::performSelectAll);
 		selectAllAction.addShortcuts(KeyboardShortcuts.SEARCH_ALL);
@@ -967,7 +966,6 @@ private void updateFromTargetSelection() {
 		String selectionText = findReplaceLogic.getTarget().getSelectionText();
 		if (selectionText.contains("\n")) { //$NON-NLS-1$
 			findReplaceLogic.deactivate(SearchOptions.GLOBAL);
-			searchInSelectionButton.setSelection(true);
 		} else if (!selectionText.isEmpty()) {
 			if (findReplaceLogic.isAvailableAndActive(SearchOptions.REGEX)) {
 				selectionText = FindReplaceDocumentAdapter.escapeForRegExPattern(selectionText);
@@ -1024,7 +1022,6 @@ public void setPositionToTop(boolean shouldPositionOverlayOnTop) {
 
 	private void removeSearchScope() {
 		findReplaceLogic.activate(SearchOptions.GLOBAL);
-		searchInSelectionButton.setSelection(false);
 	}
 
 	private void setContentAssistsEnablement(boolean enable) {