Skip to content

Commit ebf73c2

Browse files
RagiGeorgeakurtakov
authored andcommitted
Upgrade code by using instance-of pattern matching
Updated the existing code with Pattern matching to eliminate explicit type cast
1 parent db33b10 commit ebf73c2

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/ColorDefinition.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@ public boolean isEditable() {
137137

138138
@Override
139139
public boolean equals(Object obj) {
140-
if (obj instanceof ColorDefinition) {
141-
return getId().equals(((ColorDefinition) obj).getId());
140+
if (obj instanceof ColorDefinition colorDef) {
141+
return getId().equals(colorDef.getId());
142142
}
143143
return false;
144144
}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/FontDefinition.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ public boolean isEditable() {
116116

117117
@Override
118118
public boolean equals(Object obj) {
119-
if (obj instanceof FontDefinition) {
120-
return getId().equals(((FontDefinition) obj).getId());
119+
if (obj instanceof FontDefinition fontDef) {
120+
return getId().equals(fontDef.getId());
121121
}
122122
return false;
123123
}

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/ThemeElementCategory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ public String getParentId() {
105105

106106
@Override
107107
public boolean equals(Object obj) {
108-
if (obj instanceof ThemeElementCategory) {
109-
return getId().equals(((ThemeElementCategory) obj).getId());
108+
if (obj instanceof ThemeElementCategory category) {
109+
return getId().equals(category.getId());
110110
}
111111
return false;
112112
}

0 commit comments

Comments
 (0)