Eclipse 4 contributions do not allow to select svg files

[vogella]

The e4 model editor has not yet been adjusted to allow the selection of svg files via the find button.

It seems that the rendering works fine, if I use this but the find logic should also be adjusted.

To replicate, create a new plug-in with the PDE wizard and select the RCP template with sample content.
Open the Application.e4xmi and navigate to the toolbar element and use the find button after adding a svg file.

cc @HeikoKlare @Michael5601

[vogella]

Implementation seems trivial (must be done in PDE). eclipse-pde/eclipse.pde#1720

eclipse-pde/eclipse.pde#1721

[laeubi]

@vogella I think the implementation is incomplete, if one selects an SVG file, the wizard should make sure that the needed requirement is added see for example here:

• https://github.com/eclipse-platform/eclipse.platform.ui/pull/2925/files#diff-2e3ec9ee6782044d4a3f43dcaff53f6d43fd66f7a91a804ba02246ca9be74b4dR26
• https://github.com/eclipse-platform/eclipse.platform.swt/blob/cd7cd6b1f2499c8529b131dca83bc09782e02fe1/bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF#L15

[vogella]

@vogella I think the implementation is incomplete, if one selects an SVG file, the wizard should make sure that the needed requirement is added see for example here:

• https://github.com/eclipse-platform/eclipse.platform.ui/pull/2925/files#diff-2e3ec9ee6782044d4a3f43dcaff53f6d43fd66f7a91a804ba02246ca9be74b4dR26
• https://github.com/eclipse-platform/eclipse.platform.swt/blob/cd7cd6b1f2499c8529b131dca83bc09782e02fe1/bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF#L15

Can you please open a new ticket for this in PDE? Adding this would be nice, but if works also without (in the additional plug-in is available). As this is already part of the e4 feature, in most RCP applications it will be available.