Failures in org.eclipse.ui.genericeditor.tests.CompletionTest

[fedejeanne]

These 3 failed with similar stack traces in #967:

• testCompletionService
• testMoveCaretBackUsesAllProcessors_bug522255
• testCompletion

Stack traces

Unexpected second proposal item
Expected: a string ending with "s are good for a beer."
     but: was "bars are also good for soft drink cocktails."
java.lang.AssertionError: 
Unexpected second proposal item
Expected: a string ending with "s are good for a beer."
     but: was "bars are also good for soft drink cocktails."
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.ui.genericeditor.tests.CompletionTest.checkCompletionContent(CompletionTest.java:219)
	at org.eclipse.ui.genericeditor.tests.CompletionTest.testCompletionService(CompletionTest.java:127)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

---

Unexpected second proposal item
Expected: a string ending with "s are good for a beer."
     but: was "bars are also good for soft drink cocktails."
java.lang.AssertionError: 
Unexpected second proposal item
Expected: a string ending with "s are good for a beer."
     but: was "bars are also good for soft drink cocktails."
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.ui.genericeditor.tests.CompletionTest.checkCompletionContent(CompletionTest.java:219)
	at org.eclipse.ui.genericeditor.tests.CompletionTest.testMoveCaretBackUsesAllProcessors_bug522255(CompletionTest.java:264)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

---

Unexpected second proposal item
Expected: a string ending with "s are good for a beer."
     but: was "bars are also good for soft drink cocktails."
java.lang.AssertionError: 
Unexpected second proposal item
Expected: a string ending with "s are good for a beer."
     but: was "bars are also good for soft drink cocktails."
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.ui.genericeditor.tests.CompletionTest.checkCompletionContent(CompletionTest.java:219)
	at org.eclipse.ui.genericeditor.tests.CompletionTest.testCompletion(CompletionTest.java:93)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

[HeikoKlare]

These tests are now failing (also in I-Builds) because of:

• Make completion proposal calculation test time-independent #906  #967

@fedejeanne can you please revise/revert those changes?

[vogella]

Please revert the change which cases the test failure, as this currently fails all PR validations.