VirtualTableViewerTest suppresses a warning that will no longer be raised

[stephan-herrmann]

Once we merge eclipse-jdt/eclipse.jdt.core#5054 the method org.eclipse.jface.tests.viewers.VirtualTableViewerTest.testSetAllSelection() will raise a new warning:

Unnecessary @SuppressWarnings("unchecked")

At that point the suppression should simply be removed.

[stephan-herrmann]

Reviewing eclipse-jdt/eclipse.jdt.core#5054 has completed.

Should I wait for someone from platform.ui to remove the suppression that is becoming unnecessary?

I really want to get the compiler fix in for M3, but wouldn't want to unnecessarily break the SDK build.

[merks]

For M3 I expect the overnight build from Thursday to become the M3 build promoted to SimRel. So it's probably be good to submit the JDT changes ASAP and then we react downstream when that's available.

@iloveeclipse @akurtakov

Do you guys agree?

[iloveeclipse]

Yes.

[stephan-herrmann]

For M3 I expect the overnight build from Thursday to become the M3 build promoted to SimRel. So it's probably be good to submit the JDT changes ASAP and then we react downstream when that's available.

@iloveeclipse @akurtakov

Do you guys agree?

Yes

Thanks, eclipse-jdt/eclipse.jdt.core#5054 has been merged.

[iloveeclipse]

@stephan-herrmann : should I trigger SDK build to see what will be broken?

[stephan-herrmann]

@stephan-herrmann : should I trigger SDK build to see what will be broken?

I found the (single) issue in VirtualTableViewerTest by compiling a full SDK workspace with that change, but getting an official report from an SDK build surely can't hurt :)

FYI, the JDT CI build for this change is https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Github/job/master/1049/

[iloveeclipse]

I found the (single) issue in VirtualTableViewerTest by compiling a full SDK workspace with that change

Should this be fixed before SDK build?

[stephan-herrmann]

I found the (single) issue in VirtualTableViewerTest by compiling a full SDK workspace with that change

Should this be fixed before SDK build?

I'd suggest so, but you'll probably get one failure either way:

• fix before SDK build: failing CI build
• otherwise: failing SDK build

right?

[iloveeclipse]

No idea what is configured where. Sometimes jenkins or tycho configs say "warning==error", sometimes not.

I assume this is the expected fix: #3997

[iloveeclipse]

I've triggered https://ci.eclipse.org/releng/job/Builds/job/I-build-4.40/107/