Skip to content

Add Missing SVGs to Platform UI Bundles#2970

Merged
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
Michael5601:Missing-SVGs
May 14, 2025
Merged

Add Missing SVGs to Platform UI Bundles#2970
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
Michael5601:Missing-SVGs

Conversation

@Michael5601
Copy link
Copy Markdown

@Michael5601 Michael5601 commented May 12, 2025

This PR adds all missing SVG to Platform UI Bundles.

All added icons were either created by me or copied if I found a duplicate with another name.

See this PR for a description of how I created the wizban icons.

I also added SVGs for the folder org.eclipse.ui.browser/icons/clcl16 which was forgotten before. These SVGs already existed but I could not find a place where they are used. For for the sake of completeness I added them nevertheless.

All missing SVGs are documented in this issue.

@BeckerWdf
Copy link
Copy Markdown
Member

are don't you also add Wizban SVGs?

@Michael5601
Copy link
Copy Markdown
Author

Michael5601 commented May 12, 2025

are don't you also add Wizban SVGs?

They are more complex than normal icons so it requires more work to create every icon.
I will also add them soon but wanted to focus on the low hanging fruits at first.
Also I don't know how long it will take to create the wizban icons.

@BeckerWdf
Copy link
Copy Markdown
Member

are don't you also add Wizban SVGs?

They are more complex than normal icons so it requires more work to create every icon. I will also add them soon but wanted to focus on the low hanging fruits at first. Also I don't know how long it will take to create the wizban icons.

Understood.
But can't you use the exisiting SVGs for them?

@Michael5601
Copy link
Copy Markdown
Author

Michael5601 commented May 12, 2025

are don't you also add Wizban SVGs?

They are more complex than normal icons so it requires more work to create every icon. I will also add them soon but wanted to focus on the low hanging fruits at first. Also I don't know how long it will take to create the wizban icons.

Understood. But can't you use the exisiting SVGs for them?

See comment #2970 (comment)
There are no SVGs for the following three icons in the bundle org.eclipse.ltk.ui.refactoring:

wizban/apply_rescript_wiz.svg
wizban/create_rescript_wiz.svg
wizban/show_history_wiz.svg

So these need to be created.

Do I miss something here?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2025

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 39m 8s ⏱️ + 4m 24s
 7 925 tests ±0   7 697 ✅ +1  228 💤 ±0  0 ❌  - 1 
23 862 runs  ±0  23 114 ✅ +1  748 💤 ±0  0 ❌  - 1 

Results for commit 8931997. ± Comparison against base commit b337891.

♻️ This comment has been updated with latest results.

@Michael5601
Copy link
Copy Markdown
Author

are don't you also add Wizban SVGs?

I want to update my comment on this:
I found a fast way to create the wizban SVGs with only minimal drawbacks as described in PR by redrawing the bitmap in Inkscape.

I created the missing wizban icons for all Platform bundles and will proceed to create them in this PR for Platform UI bundles too.

Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing the SVGs!
In general the PR looks good. I just saw that the SVGs in org.eclipse.ui.browser are already referenced in code even though they did not exist, so it makes sense to have them in as soon as possible.

I am a bit concerned regarding the wizard banner icons: they are pretty huge (almost 1 MB) and they seem to be no proper vector graphics but just the original pixels represented as vectors. This, in my opinion, leads to even worse results when they are rescaled, as no anti-aliasted scaling is performed. See the scaled PNG (left) and the scaled SVG (right) in the following screenshot:
image

So I propose to exclude the wizard banners for now and find a proper way of replacing them with SVGs.

This commit adds all missing SVGs to Platform UI Bundles.
Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the wizard banner icons for the mentioned reasons again to make this PR ready to merge. We should have a separate look at them.

@BeckerWdf
Copy link
Copy Markdown
Member

I've removed the wizard banner icons for the mentioned reasons again to make this PR ready to merge. We should have a separate look at them.

See eclipse-platform/eclipse.platform.images#144. There is have created SVGs for two of them.

@HeikoKlare HeikoKlare merged commit fccc7b7 into eclipse-platform:master May 14, 2025
18 checks passed
@Michael5601 Michael5601 deleted the Missing-SVGs branch June 2, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants