Add Missing SVGs to Platform UI Bundles#2970
Conversation
|
are don't you also add Wizban SVGs? |
They are more complex than normal icons so it requires more work to create every icon. |
Understood. |
See comment #2970 (comment)
|
I want to update my comment on this: I created the missing wizban icons for all Platform bundles and will proceed to create them in this PR for Platform UI bundles too. |
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for providing the SVGs!
In general the PR looks good. I just saw that the SVGs in org.eclipse.ui.browser are already referenced in code even though they did not exist, so it makes sense to have them in as soon as possible.
I am a bit concerned regarding the wizard banner icons: they are pretty huge (almost 1 MB) and they seem to be no proper vector graphics but just the original pixels represented as vectors. This, in my opinion, leads to even worse results when they are rescaled, as no anti-aliasted scaling is performed. See the scaled PNG (left) and the scaled SVG (right) in the following screenshot:

So I propose to exclude the wizard banners for now and find a proper way of replacing them with SVGs.
This commit adds all missing SVGs to Platform UI Bundles.
HeikoKlare
left a comment
There was a problem hiding this comment.
I've removed the wizard banner icons for the mentioned reasons again to make this PR ready to merge. We should have a separate look at them.
See eclipse-platform/eclipse.platform.images#144. There is have created SVGs for two of them. |
This PR adds all missing SVG to Platform UI Bundles.
All added icons were either created by me or copied if I found a duplicate with another name.
See this PR for a description of how I created the wizban icons.
I also added SVGs for the folder
org.eclipse.ui.browser/icons/clcl16which was forgotten before. These SVGs already existed but I could not find a place where they are used. For for the sake of completeness I added them nevertheless.All missing SVGs are documented in this issue.