Skip to content

Add missing SVG wizard banner icon in org.eclipse.ltk.ui.refactoring#2983

Merged
vogella merged 1 commit into
eclipse-platform:masterfrom
BeckerWdf:ShowRefactoringHistoryWizard
May 15, 2025
Merged

Add missing SVG wizard banner icon in org.eclipse.ltk.ui.refactoring#2983
vogella merged 1 commit into
eclipse-platform:masterfrom
BeckerWdf:ShowRefactoringHistoryWizard

Conversation

@BeckerWdf
Copy link
Copy Markdown
Member

This adds SVG versions of the banners for the "Show Refactoring History Wizard".

See also eclipse-platform/eclipse.platform.images#145

This adds SVG versions of the banners for the "Show Refactoring
History Wizard".
@BeckerWdf BeckerWdf requested a review from HeikoKlare May 15, 2025 06:52
@BeckerWdf
Copy link
Copy Markdown
Member Author

Shouldn't we also delete the now unused PNGs?

@HeikoKlare
Copy link
Copy Markdown
Contributor

Thank you for creating the icon!

Shouldn't we also delete the now unused PNGs?

Currently, we consider the PNG icons as deprecated for removal (i.e., to be removed in 2 years) and mention that in the according news: https://eclipse.dev/eclipse/markdown/?f=news/4.36/platform.md#support-for-svg-images
If I am not mistaken, this was what we agreed on in a community call to ensure that consumers bundles having direct references to those resources inside bundle have some time to adapt (if they even get aware of the upcoming removal as we cannot provide the information via code). Should we reconsider the decision?

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 37m 22s ⏱️ -36s
 7 925 tests ±0   7 697 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 862 runs  ±0  23 114 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit 86d43eb. ± Comparison against base commit 13d5c4f.

@vogella vogella merged commit 208faf9 into eclipse-platform:master May 15, 2025
18 checks passed
@BeckerWdf BeckerWdf deleted the ShowRefactoringHistoryWizard branch May 15, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants