Incorrect Colors in LTK Refactoring Preview Wizard#3777
Merged
iloveeclipse merged 2 commits intoeclipse-platform:masterfrom Mar 15, 2026
Merged
Incorrect Colors in LTK Refactoring Preview Wizard#3777iloveeclipse merged 2 commits intoeclipse-platform:masterfrom
iloveeclipse merged 2 commits intoeclipse-platform:masterfrom
Conversation
Change left/right diff elements in refactoring wizard to get proper diff coloring. This would make the "diff order" consistent with the **current** Eclipse diff order, which is, let say, "unusual" for a very long time (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=213780). That is also the reason the refactoring wizard had always "swapped" the input sides, being inconsistent to provide expected usability. However the coloring can be consistent only if the diff order is default one, and since diff coloring was added, refactoring wizard "hack" became visible. See also eclipse-platform#3776. This PR depends on eclipse-platform/eclipse.platform#2566 to avoid unexpected change of the "usual" diff order in the refactoring wizard. Fixes eclipse-platform#3775
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Test Results 852 files - 2 058 852 suites - 2 058 58m 37s ⏱️ - 1h 3m 27s Results for commit 7f2ea20. ± Comparison against base commit ae64c28. This pull request removes 5800 and adds 5940 tests. Note that renamed tests count towards both.This pull request removes 119 skipped tests and adds 119 skipped tests. Note that renamed tests count towards both. |
This was referenced May 6, 2026
Make JUnit diff order consistent with the default compare diff order
eclipse-jdt/eclipse.jdt.ui#2976
Merged
iloveeclipse
added a commit
to iloveeclipse/eclipse.jdt.ui
that referenced
this pull request
May 7, 2026
Similar to the refactoring wizard, JUnit diff order was always NOT following "traditional" Eclipse compare editor diff order (left is "new", right is "old"), so that "natural" order expected / actual was inconsistent with the compare editor preference, but it was based on this preference (via CompareConfiguration). Now the "natural" order is default, swap the sides in JUNit diff pane to keep same order in as before left: expected, right: actual. See eclipse-platform/eclipse.platform#2566 See eclipse-platform/eclipse.platform.ui#3777 See eclipse-platform/eclipse.platform.ui#3776 (comment)
iloveeclipse
added a commit
to iloveeclipse/eclipse.jdt.ui
that referenced
this pull request
May 7, 2026
Similar to the refactoring wizard, JUnit diff order was always NOT following "traditional" Eclipse compare editor diff order (left is "new", right is "old"), so that "natural" order expected / actual was inconsistent with the compare editor preference, but it was based on this preference (via CompareConfiguration). Now the "natural" order is default, swap the sides in JUNit diff pane to keep same order in as before left: expected, right: actual. As expected "side effect", this patch fixes exact same problem refactoring wizard had with wrong colors applied, where deletion and addition were using wrong colors. See eclipse-platform/eclipse.platform#2566 See eclipse-platform/eclipse.platform.ui#3777 See eclipse-platform/eclipse.platform.ui#3776 (comment)
iloveeclipse
added a commit
to eclipse-jdt/eclipse.jdt.ui
that referenced
this pull request
May 7, 2026
Similar to the refactoring wizard, JUnit diff order was always NOT following "traditional" Eclipse compare editor diff order (left is "new", right is "old"), so that "natural" order expected / actual was inconsistent with the compare editor preference, but it was based on this preference (via CompareConfiguration). Now the "natural" order is default, swap the sides in JUNit diff pane to keep same order in as before left: expected, right: actual. As expected "side effect", this patch fixes exact same problem refactoring wizard had with wrong colors applied, where deletion and addition were using wrong colors. See eclipse-platform/eclipse.platform#2566 See eclipse-platform/eclipse.platform.ui#3777 See eclipse-platform/eclipse.platform.ui#3776 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change left/right diff elements in refactoring wizard to get proper diff coloring.
This would make the "diff order" consistent with the current Eclipse diff order, which is, let say, "unusual" for a very long time (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=213780). That is also the reason the refactoring wizard had always "swapped" the input sides, being inconsistent to provide expected usability. However the coloring can be consistent only if the diff order is default one, and since diff coloring was added, refactoring wizard "hack" became visible.
See also #3776.
This PR depends on eclipse-platform/eclipse.platform#2566 to avoid unexpected change of the "usual" diff order in the refactoring wizard.
Fixes #3775