Scope default theme preference by product or application#3878
Merged
vogella merged 2 commits intoeclipse-platform:masterfrom Apr 10, 2026
Merged
Scope default theme preference by product or application#3878vogella merged 2 commits intoeclipse-platform:masterfrom
vogella merged 2 commits intoeclipse-platform:masterfrom
Conversation
Contributor
Test Results 852 files ±0 852 suites ±0 52m 36s ⏱️ + 1m 38s For more details on these failures, see this check. Results for commit 215b38e. ± Comparison against base commit 1375cd4. ♻️ This comment has been updated with latest results. |
The default theme preference is now stored under a product-specific (or application-specific) sub-node in user scope. This allows different Eclipse-based products sharing the same user preferences location to maintain independent theme defaults. When reading the preference, the product ID (from Platform.getProduct()) is used as the sub-node key. If no product is configured, the application ID (eclipse.application system property) is used as fallback. If neither is available, the preference is stored at the base node level. This also migrates the 'Manage default theme' dialog from ConfigurationScope to UserScope to be consistent with the rest of the theme preference handling.
The dialog now displays which product or application the default theme applies to, making it transparent that theme defaults are scoped. Examples: - With product: 'Current default theme for Eclipse SDK (org.eclipse.sdk.ide): Dark' - Without product: 'Current default theme for org.eclipse.ui.ide.workbench (org.eclipse.ui.ide.workbench): Dark' - Without either: falls back to unscoped messages
vogella
force-pushed
the
product-scoped-theme-preference
branch
from
5ae3993 to
215b38e
Compare
Contributor
Author
|
Test failures are unrelated #3880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default theme preference is now stored under a product-specific (or application-specific) sub-node in user scope. This allows different Eclipse-based products sharing the same user preferences to maintain independent theme defaults.
Changes
UserScope/org.eclipse.e4.ui.css.swt.theme/<productId>/themeidPlatform.getProduct().getId()eclipse.applicationsystem property if no product is configuredConfigurationScopetoUserScopefor consistencyFiles changed
E4Application.java- reads product-scoped theme on startupViewsPreferencePage.java- writes product-scoped theme in preference dialogs