Replace Forms API with plain SWT in workspace dialogs#3881
Replace Forms API with plain SWT in workspace dialogs#3881vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
|
Note to myself: Need to build aggregator with this change to see recent workspace in action, configuration scope is not shared in runtime Eclipse. |
|
Note that notes to yourself along with drafts generate emails for everyone. Please consider completing work before publicizing it as a draft. |
Sure, I will try to handle more developments via branches on my forks. |
Test Results 852 files ±0 852 suites ±0 53m 10s ⏱️ - 4m 27s For more details on these failures, see this check. Results for commit 4394174. ± Comparison against base commit 357b87c. ♻️ This comment has been updated with latest results. |
Remove dependency on FormToolkit, ExpandableComposite, and ScrolledForm in ChooseWorkspaceDialog and ChooseWorkspaceWithSettingsDialog. Replace with plain SWT composites and Labels with Unicode triangle characters (U+25B8 ▸ / U+25BE ▾) for the expand/collapse toggle. This improves dialog startup performance by eliminating the Forms overhead: extra decorated composites, global paint/focus listeners, color management, and recursive ScrolledForm reflow on each toggle. The Unicode triangles are from the Geometric Shapes block (Unicode 1.0) and render reliably on Windows, macOS, and Linux system fonts. Also fix layout data mismatch where the path Combo used GridData inside a BorderLayout container (now uses BorderData).
vogella
force-pushed
the
replace-forms-api-workspace-dialogs
branch
from
b72c257 to
4394174
Compare
2 participants
Remove dependency on FormToolkit, ExpandableComposite, and ScrolledForm in ChooseWorkspaceDialog and ChooseWorkspaceWithSettingsDialog. Replace with plain SWT composites and Labels with Unicode triangle characters (▸/▾) for the expand/collapse toggle.
Benefits: