Set proper default for monitor-specific scaling preference#4005
Merged
HeikoKlare merged 2 commits intoMay 30, 2026
Merged
Conversation
Contributor
HeikoKlare
marked this pull request as ready for review
May 15, 2026 12:15
fedejeanne
approved these changes
May 29, 2026
fedejeanne
left a comment
fedejeanne
left a comment
Member
There was a problem hiding this comment.
Works as expected.
Hint for testing
When testing this across restarts and using a launch configuration (i.e. when launching it from the IDE), make sure that you do not clear the configuration area before launching, otherwise the value is always reset to true (selected) upon restarts:
When restoring the default values for the "Appearance" preference page, the Windows-specific preference for enabling/disabling monitor-specific scaling is not updated. The default value for this preference is currently defined at every place accessing the preference redundantly. With this change, a proper default value in the default preference scope is defined for the monitor-specific scaling preference. This value is used by all consumers of the preference via a ScopedPreferenceStore. The defaults restoration of the "Appearance" preference page is extended with a restore of the monitor-specific scaling preference.
HeikoKlare
force-pushed
the
monitor-specific-scaling-restore-default
branch
from
May 30, 2026 10:11
fdfa795 to
ce8bd9e
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring the default values for the "Appearance" preference page, the Windows-specific preference for enabling/disabling monitor-specific scaling is not updated. The default value for this preference is currently defined at every place accessing the preference redundantly.
With this change, a proper default value in the default preference scope is defined for the monitor-specific scaling preference. This value is used by all consumers of the preference via a ScopedPreferenceStore. The defaults restoration of the "Appearance" preference page is extended with a restore of the monitor-specific scaling preference.
How to test
Open the "Apperance" page of the preference dialog and press "Restore Defaults". Without this change, the "Use monitor-specific UI scaling" option will not change. With this change, the default value (enabled) will be applied.