Remove unnecessary "Apply and Close" button from Properties dialog#4014
Conversation
Shown "Close" instead of "Cancel" would even be better from my point of view. |
408812a to
6651650
Compare
|
This is the updated view with close option : 
|
This commit retains only the cancel button and eliminates the Apply and close button in the property dialog which is unnecessary in the current context there. There is only a description provided in the property dialog and there is no event that needs an apply option. Fixes: eclipse-equinox/p2#1049
6651650 to
c8a2696
Compare
|
build looks good; merging this now; |
|
This introduces regression elsewhere! Right click any project, see a property page for the project that now has no "Apply and Close" button, only separated "Apply" and "Close". 
After: 
Please revert the change or provide a fix that doesn't affect other components. |
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify the Properties dialog UI by removing the redundant “Apply and Close” button when the dialog is effectively read-only (as described for Installation Details → Properties), to avoid confusing users.
Changes:
- Overrides the Properties dialog button bar to show a single Close button instead of the default Apply and Close / Cancel buttons.
- Routes Close button handling through cancel semantics (
cancelPressed()). - Overrides
updateButtons()as a no-op to avoid relying on the default OK-button enablement logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @Override | ||
| protected void buttonPressed(int buttonId) { | ||
| if (buttonId == IDialogConstants.CLOSE_ID) { | ||
| cancelPressed(); | ||
| return; | ||
| } | ||
| super.buttonPressed(buttonId); | ||
| } | ||
|
|
||
| @Override | ||
| protected void createButtonsForButtonBar(Composite parent) { | ||
| createButton(parent, IDialogConstants.CLOSE_ID, IDialogConstants.CLOSE_LABEL, true); | ||
| } |
| @Override | ||
| public void updateButtons() { | ||
| // This function is overridden to remove the Apply and close button | ||
| } |
| @Override | ||
| protected void buttonPressed(int buttonId) { | ||
| if (buttonId == IDialogConstants.CLOSE_ID) { | ||
| cancelPressed(); | ||
| return; | ||
| } | ||
| super.buttonPressed(buttonId); | ||
| } |
|
I will revert this change for now; |
The Properties dialog opened from
Installation Details → Propertiesdoes not have any option to edit or make any modifications to the properties. Despite this it still displays bothCancelandApply and Closebuttons.Since no changes can be made in this dialog, the
Apply and Closebutton is basically redundant here and performs the same action asCancel. This could be confusing to the users hence this commit removes the unnecessaryApply and Closebutton and retain only thecanceloption.Fixes :eclipse-equinox/p2#1049
Before:
After:
