Skip to content

Remove unnecessary "Apply and Close" button from Properties dialog #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elsazac merged 1 commit into from
Jun 1, 2026
Merged

Remove unnecessary "Apply and Close" button from Properties dialog #4014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ...es/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/PropertyDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@

import java.util.Iterator;
import org.eclipse.core.runtime.Adapters;
import org.eclipse.jface.dialogs.IDialogConstants;
import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.preference.IPreferenceNode;
import org.eclipse.jface.preference.PreferenceManager;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.StructuredSelection;
import org.eclipse.osgi.util.NLS;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.ui.PlatformUI;
Expand Down Expand Up @@ -90,6 +92,20 @@ public static PropertyDialog createDialogOn(Shell shell, final String propertyPa
return propertyDialog;

}

@Override
protected void buttonPressed(int buttonId) {
if (buttonId == IDialogConstants.CLOSE_ID) {
cancelPressed();
return;
}
super.buttonPressed(buttonId);
}
Comment on lines +96 to +103

@Override
protected void createButtonsForButtonBar(Composite parent) {
createButton(parent, IDialogConstants.CLOSE_ID, IDialogConstants.CLOSE_LABEL, true);
}
Comment on lines +96 to +108

@Override
protected void addButtonsToHelpControl(Control control) {
Expand Down Expand Up @@ -162,6 +178,11 @@ protected String getSelectedNodePreference() {
return lastPropertyId;
}

@Override
public void updateButtons() {
// This function is overridden to remove the Apply and close button
}
Comment on lines +181 to +184

/**
* Get the name of the selected item preference
*/
Expand Down
Loading