Restore bounded wait in QuickAccessDialogTest to avoid bundle timeout#4096
Merged
vogella merged 1 commit intoJun 15, 2026
Merged
Conversation
The wait for the dialog initialization in testPreviousChoicesAvailableForExtension used TIMEOUT * 1000, about 83 minutes. When the dialog initialization stalls (notably on macOS), this wait blocks far past the 1200s tycho-surefire budget for the whole org.eclipse.ui.tests bundle, so the test runtime is killed with SIGTERM (exit code 143) and no test results are reported for the bundle. Restoring the wait to TIMEOUT lets the test fail fast and locally instead of hanging and taking down the entire bundle. See eclipse-platform#4009
Contributor
Author
|
@trancexpress the 83 min timeout which you places here, look like a typo to me and leads to process killing for the verification jobs. I suggest we change it back to the regular timeout to get a reasonable feedback (test errors) instead of a killed process. |
Contributor
|
@vogella sorry! I must have committed a debug change without realizing it... |
Contributor
Contributor
Author
No worries, the timeout kill was just misleading for me, I assumed for a few days that we have an infrastructure problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialog-initialization wait in
testPreviousChoicesAvailableForExtensionwas set toTIMEOUT * 1000, roughly 83 minutes. When the dialog initialization stalls, which happens on the macOS CI runners, the wait blocks well past the 1200s tycho-surefire budget for the wholeorg.eclipse.ui.testsbundle, so the test runtime is killed with SIGTERM (exit code 143). Maven then reports a launch failure with no test results, which is why the macOS validation has been failing for every PR without pointing at a specific test.Restoring the wait to
TIMEOUTmakes the test fail fast and locally when the dialog does not initialize, instead of hanging and taking the entire bundle down with it. The underlying race that leaves the proposals empty is addressed separately in #4090; this change only removes the accidental long wait so failures stay attributable and the bundle keeps reporting results. See #4009.