From c09b7f98c634f31c011e077645b091b0752f8acb Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Mon, 15 Jun 2026 13:08:11 +0200 Subject: [PATCH] Restore bounded wait in QuickAccessDialogTest to avoid bundle timeout The wait for the dialog initialization in testPreviousChoicesAvailableForExtension used TIMEOUT * 1000, about 83 minutes. When the dialog initialization stalls (notably on macOS), this wait blocks far past the 1200s tycho-surefire budget for the whole org.eclipse.ui.tests bundle, so the test runtime is killed with SIGTERM (exit code 143) and no test results are reported for the bundle. Restoring the wait to TIMEOUT lets the test fail fast and locally instead of hanging and taking down the entire bundle. See #4009 --- .../org/eclipse/ui/tests/quickaccess/QuickAccessDialogTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/quickaccess/QuickAccessDialogTest.java b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/quickaccess/QuickAccessDialogTest.java index c9dd5d7b920..d51e07ab510 100644 --- a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/quickaccess/QuickAccessDialogTest.java +++ b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/quickaccess/QuickAccessDialogTest.java @@ -321,7 +321,7 @@ public void testPreviousChoicesAvailableForExtension() { * wait for the dialog initialization, to avoid race conditions later on in the test, see: * https://github.com/eclipse-platform/eclipse.platform.ui/issues/4009 */ - assertTrue(DisplayHelper.waitForCondition(text.getDisplay(), TIMEOUT * 1000, + assertTrue(DisplayHelper.waitForCondition(text.getDisplay(), TIMEOUT, () -> dialog.infoText != null), "Unexpected dialog info: " + dialog.infoText); text.setText(TestQuickAccessComputer.TEST_QUICK_ACCESS_PROPOSAL_LABEL);