Add family for the quick diff initialize job#4173
Merged
Merged
Conversation
The quick diff initialization job currently has no family, making it difficult to wait on it during tests. During JDT UI SaveParticipantTest we observe the job running in parallel to the test, potentially running into errors due to file operations done in the test. This change adds a family that tests can use to wait on the job. Fixes: eclipse-platform#4172 See also: eclipse-jdt/eclipse.jdt.ui#79
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quick diff initialization job currently has no family, making it difficult to wait on it during tests.
During JDT UI
SaveParticipantTestwe observe the job running in parallel to the test, potentially running into errors due to file operations done in the test.This change adds a family that tests can use to wait on the job.
Fixes: #4172
See also: eclipse-jdt/eclipse.jdt.ui#79