Skip to content

Register model-contributed perspectives in PerspectiveRegistry#4174

Merged
akurtakov merged 1 commit into
eclipse-platform:masterfrom
akurtakov:perspective-registry-model-perspectives
Jul 9, 2026
Merged

Register model-contributed perspectives in PerspectiveRegistry#4174
akurtakov merged 1 commit into
eclipse-platform:masterfrom
akurtakov:perspective-registry-model-perspectives

Conversation

@akurtakov

Copy link
Copy Markdown
Member

Perspectives contributed directly into the application model (e.g. as children of a perspective stack via a model fragment) rather than through the org.eclipse.ui.perspectives extension point or as application snippets were unknown to the PerspectiveRegistry, and therefore invisible to the "Open Perspective" dialog and unresolvable by id.

Scan the model for such perspectives and register descriptors for them, both at startup and lazily from getPerspectives(). Add a test covering a model-contributed perspective.

Perspectives contributed directly into the application model (e.g. as
children of a perspective stack via a model fragment) rather than through
the org.eclipse.ui.perspectives extension point or as application snippets
were unknown to the PerspectiveRegistry, and therefore invisible to the
"Open Perspective" dialog and unresolvable by id.

Scan the model for such perspectives and register descriptors for them,
both at startup and lazily from getPerspectives(). Add a test covering a
model-contributed perspective.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@merks merks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Test Results

   855 files  ±0     855 suites  ±0   55m 32s ⏱️ + 1m 21s
 8 110 tests +1   7 867 ✅ +1  243 💤 ±0  0 ❌ ±0 
20 232 runs  +3  19 578 ✅ +3  654 💤 ±0  0 ❌ ±0 

Results for commit 11a85c8. ± Comparison against base commit 51815e5.

@akurtakov akurtakov merged commit 2597f7f into eclipse-platform:master Jul 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants