Skip to content

Stabilize SortingTest match count #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Jul 10, 2026
+4 −3
Merged

Stabilize SortingTest match count #4177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/org.eclipse.search.tests/src/org/eclipse/search/tests/filesearch/SortingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,16 @@ public void testSorted() throws Exception {
NewSearchUI.activateSearchResultView();
NewSearchUI.runQueryInForeground(null, fQuery1);
AbstractTextSearchResult result= (AbstractTextSearchResult) fQuery1.getSearchResult();
int originalMatchCount= result.getMatchCount();
List<Match> allMatches= new ArrayList<>(originalMatchCount);
List<Match> allMatches= new ArrayList<>(result.getMatchCount());
int originalMatchCount= 0;

// first, collect all matches
Object[] elements= result.getElements();
for (Object element : elements) {
int sizeBefore= allMatches.size();
Match[] matches = result.getMatches(element);
Collections.addAll(allMatches, matches);
originalMatchCount += matches.length;
int sizeAfter= allMatches.size();
assertEquals(sizeBefore + matches.length, sizeAfter, "Failed to add matches:" +
Arrays.stream(matches).map(Match::toString).collect(Collectors.joining(System.lineSeparator())));
Expand All @@ -80,7 +81,7 @@ public void testSorted() throws Exception {
assertEquals(sizeBefore + 1, sizeAfter, "Failed to add match:" + match);
}

assertEquals(result.getMatchCount(), originalMatchCount, "Test that all matches have been added again");
assertEquals(originalMatchCount, result.getMatchCount(), "Test that all matches have been added again");

// now check that they're ordered by position.
for (Object element : elements) {
Expand Down
Loading