Filtered tree is implemented for Marker Support Views. - #4208
Conversation
Bookmarks View, Problems View and Tasks Views will have a search filter box. see eclipse-platform#4204
|
@iloveeclipse Initial implementation of filtered tree.. Please check if it looks good. |
There was a problem hiding this comment.
Pull request overview
This PR adds a search-based filtering UI (a FilteredTree search box) to Marker Support Views (e.g., Bookmarks/Problems/Tasks) by wrapping the existing markers TreeViewer in a filtered tree and providing a marker-specific PatternFilter implementation.
Changes:
- Introduces a
MarkersFilteredTreethat hosts the existingMarkersTreeViewerwhile adding a filter text box. - Adds
MarkerPatternFilterto match markers against the values of all currently visible marker fields/columns. - Externalizes the filter box initial text and adds the required bundle dependency for
org.eclipse.e4.ui.dialogs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/messages.properties | Adds an externalized string for the filter box initial text. |
| bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerMessages.java | Adds the corresponding NLS field for the new message key. |
| bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkersFilteredTree.java | New FilteredTree subclass that creates the markers-specific TreeViewer. |
| bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerPatternFilter.java | New PatternFilter that matches concrete markers based on visible column values. |
| bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ExtendedMarkersView.java | Replaces direct Tree creation with the new filtered tree and wires the initial text. |
| bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF | Adds org.eclipse.e4.ui.dialogs to Require-Bundle for FilteredTree/PatternFilter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Is it possible to hide the filter line (like in the Error Log view)? |
I will implement a preference for this like Error Log view. Which can be turned ON and OFF. |
| } | ||
|
|
||
| @Override | ||
| protected TreeViewer doCreateTreeViewer(Composite parent, int style) { |
There was a problem hiding this comment.
Please rename the parameter, see compiler warning below which fails the build validation.
Bookmarks View, Problems View and Tasks Views will have a search filter box.
see #4204