From d099cbaeba3ffb209805959ddec0ee04b07827c5 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Tue, 28 Jul 2026 12:29:31 +0200 Subject: [PATCH] Remove blind settle delay from code mining test fixtures CodeMiningTest.setUp() and CodeMiningLineHeaderAnnotationTest.setUp() both ended with DisplayHelper.sleep(display, 1000), placed directly after a waitForCondition() that had already established that the text widget is visible. DisplayHelper.sleep() is waitForCondition() with the condition hardcoded to false, so it always burns the full second. CodeMiningTest installs its provider on an empty document, and the provider skips blank lines, so no code minings are produced during setUp and there is nothing to settle for. Measured on a full CI run, CodeMiningTest is 22.6s over 19 tests with a median of 1.04s against a minimum of 0.19s, and CodeMiningLineHeaderAnnotationTest is 4.0s over 4 tests with minimum and median both 1.01s. --- .../tests/codemining/CodeMiningLineHeaderAnnotationTest.java | 1 - .../org/eclipse/jface/text/tests/codemining/CodeMiningTest.java | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningLineHeaderAnnotationTest.java b/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningLineHeaderAnnotationTest.java index 859e3294178..f8e2dc19b25 100644 --- a/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningLineHeaderAnnotationTest.java +++ b/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningLineHeaderAnnotationTest.java @@ -70,7 +70,6 @@ protected boolean condition() { return fViewer.getTextWidget().isVisible(); } }.waitForCondition(display, 3000)); - DisplayHelper.sleep(textWidget.getDisplay(), 1000); } @AfterEach diff --git a/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java b/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java index 0cb6bfdbfa6..80ffa8985ab 100644 --- a/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java +++ b/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java @@ -132,7 +132,6 @@ protected boolean condition() { return fViewer.getTextWidget().isVisible(); } }.waitForCondition(display, 3000)); - DisplayHelper.sleep(textWidget.getDisplay(), 1000); } @AfterEach