Make completion proposal calculation test time-independent #906 #967
Merged
fedejeanne merged 1 commit intoeclipse-platform:masterfrom Apr 9, 2026
Merged
Conversation
Contributor
Test Results 852 files ±0 852 suites ±0 52m 52s ⏱️ - 6m 20s For more details on these failures, see this check. Results for commit 3cc7694. ± Comparison against base commit f1a031a. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-906-performance
branch
from
d0900c8 to
f7c555a
Compare
fedejeanne
reviewed
Jul 26, 2023
...c/org/eclipse/ui/genericeditor/tests/contributions/LongRunningBarContentAssistProcessor.java
Outdated
Show resolved
Hide resolved
fedejeanne
reviewed
Jul 26, 2023
...c/org/eclipse/ui/genericeditor/tests/contributions/LongRunningBarContentAssistProcessor.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
issue-906-performance
branch
2 times, most recently
from
286908a to
99f9419
Compare
HeikoKlare
changed the title
HeikoKlare
force-pushed
the
issue-906-performance
branch
from
99f9419 to
0b34f69
Compare
Member
|
Hey, Codex here. The follow-up branch I mentioned is now published on the fork as |
fedejeanne
force-pushed
the
issue-906-performance
branch
from
0b34f69 to
ffe4d84
Compare
…atform#906 The test cases for completion proposals in CompletionTest depend on specific timing behavior of a test proposal processor. On one hand, this is prone to errors if proper timing is not given on the test environment. On the other hand, the tests run unnecessarily long because of waiting long enough. This change replaces the fixed-time waiting of the LongRunningBarContentAssistProcessor with an explicit trigger that finalizes the content calculation as soon as some barrier is reached within the tests. In addition, the long-running processor is only enabled on demand and will be finalized whenever a test case was executed to avoid that the processor thread is leaking to the next test case. Contributes to eclipse-platform#906
fedejeanne
force-pushed
the
issue-906-performance
branch
from
ffe4d84 to
3cc7694
Compare
Member
|
Test failures are unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test cases for completion proposals in
CompletionTestdepend on specific timing behavior of a test proposal processor. On one hand, this is prone to errors if proper timing is not given on the test environment. On the other hand, the tests run unnecessarily long because of waiting long enough.This change replaces the fixed-time waiting of the
LongRunningBarContentAssistProcessorwith an explicit trigger that finalizes the content calculation as soon as some barrier is reached within the tests. In addition, the long-running processor is only enabled on demand and will be finalized whenever a test case was executed to avoid that the processor thread is leaking to the next test case.Contributes to #906