Skip to content

Commit 0eda9f4

Browse files
committed
Log resource deltas in all of MarkerTest, cancel and join descriptions cache flush
This change adds resource delta logging to all test methods of MarkerTest. Additionally, it cancels and joins ContentDescriptionManager.FlushJob so that the job doesn't notify the test listener with deltas. See: #2569
1 parent c062420 commit 0eda9f4

File tree

1 file changed

+10
-2
lines changed
  • resources/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources

1 file changed

+10
-2
lines changed

resources/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/MarkerTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
import java.util.Vector;
4545
import java.util.concurrent.atomic.AtomicReference;
4646
import org.assertj.core.api.ObjectAssert;
47+
import org.eclipse.core.internal.resources.ContentDescriptionManager;
4748
import org.eclipse.core.internal.resources.MarkerManager;
4849
import org.eclipse.core.internal.resources.MarkerReader;
4950
import org.eclipse.core.internal.resources.Resource;
@@ -208,6 +209,8 @@ public void setUp() throws Exception {
208209
prefs.putBoolean(ResourcesPlugin.PREF_AUTO_REFRESH, false);
209210
Job.getJobManager().wakeUp(ResourcesPlugin.FAMILY_AUTO_REFRESH);
210211
Job.getJobManager().join(ResourcesPlugin.FAMILY_AUTO_REFRESH, null);
212+
ResourcesPlugin.getWorkspace().addResourceChangeListener(LOG_RESOURCE_DELTA);
213+
cancelAndJoin(ContentDescriptionManager.FAMILY_DESCRIPTION_CACHE_FLUSH);
211214
}
212215

213216

@@ -958,7 +961,6 @@ public void testMarkerDeltasMoveFolder(TestInfo testInfo) throws CoreException {
958961
*/
959962
@Test
960963
public void testMarkerDeltasMoveFile(TestInfo testInfo) throws CoreException {
961-
ResourcesPlugin.getWorkspace().addResourceChangeListener(LOG_RESOURCE_DELTA);
962964
IWorkspaceRoot root = getWorkspace().getRoot();
963965
final IProject project = root.getProject("MyProject");
964966
IFolder folder = project.getFolder("folder");
@@ -1006,7 +1008,7 @@ public void testMarkerDeltasMoveFile(TestInfo testInfo) throws CoreException {
10061008
* Tests the appearance of marker changes in the resource delta.
10071009
*/
10081010
@Test
1009-
public void testMarkerDeltasMoveProject() throws CoreException {
1011+
public void testMarkerDeltasMoveProject() throws Exception {
10101012
// Create and register a listener.
10111013
final MarkersChangeListener listener = new MarkersChangeListener();
10121014
setResourceChangeListener(listener);
@@ -1036,6 +1038,7 @@ public void testMarkerDeltasMoveProject() throws CoreException {
10361038
IPath destination = IPath.fromOSString(project.getName() + "move");
10371039
project.move(destination, true, createTestMonitor());
10381040
}
1041+
cancelAndJoin(ContentDescriptionManager.FAMILY_DESCRIPTION_CACHE_FLUSH);
10391042

10401043
// verify marker deltas
10411044
IResourceVisitor visitor = resource -> {
@@ -1393,6 +1396,11 @@ public void testSetGetAttribute2() throws CoreException {
13931396
}
13941397
}
13951398

1399+
private static void cancelAndJoin(Object family) throws Exception {
1400+
Job.getJobManager().cancel(family);
1401+
Job.getJobManager().join(family, null);
1402+
}
1403+
13961404
private static void logDeltaEvent(IResourceChangeEvent event) {
13971405
StringBuilder s = new StringBuilder();
13981406
s.append("Logging resource change event");

0 commit comments

Comments
 (0)