Don't use display thread for scheduling console update tasks

This fixes regression from 7e1f60c, where main thread (which owns lock
on UI operations) waits for the lock on ProcessConsole to update console
name but never gets it because console code is blocked internally
waiting for a QueueProcessingJob being executed on UI thread.

The solution is to avoid direct calls from UI to
ProcessConsole.resetName().

Fixes #2460

Author: iloveeclipse

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/console/ProcessConsole.java

@@ -37,6 +37,10 @@
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
 import java.util.regex.Pattern;
 
 import org.eclipse.core.resources.IFile;
@@ -139,6 +143,9 @@ public class ProcessConsole extends IOConsole implements IConsole, IDebugEventSe
 
 	private volatile boolean fStreamsClosed;
 
+	private final ScheduledExecutorService consoleNameUpdateExecutor;
+	private volatile ScheduledFuture<?> pendingNameUpdate;
+
 	/**
 	 * Create process console with default encoding.
 	 *
@@ -160,7 +167,11 @@ public ProcessConsole(IProcess process, IConsoleColorProvider colorProvider, Str
 		super(IInternalDebugCoreConstants.EMPTY_STRING, IDebugUIConstants.ID_PROCESS_CONSOLE_TYPE, null, encoding, true);
 		fProcess = process;
 		fUserInput = getInputStream();
-
+		consoleNameUpdateExecutor = Executors.newSingleThreadScheduledExecutor(r -> {
+			Thread t = new Thread(r, "Console name updater"); //$NON-NLS-1$
+			t.setDaemon(true);
+			return t;
+		});
 		ILaunchConfiguration configuration = process.getLaunch().getLaunchConfiguration();
 		String file = null;
 		boolean append = false;
@@ -349,9 +360,14 @@ protected String computeName() {
 					DateFormat dateTimeFormat = DateFormat.getDateTimeInstance(DateFormat.MEDIUM, DateFormat.MEDIUM);
 					String elapsedFormat = "%d:%02d:%02d.%03d"; //$NON-NLS-1$
 					if (terminateTime == null) {
-						// refresh every second:
-						DebugUIPlugin.getStandardDisplay().asyncExec(
-								() -> DebugUIPlugin.getStandardDisplay().timerExec(1000, () -> resetName(false)));
+						// refresh every second, but only if not already scheduled:
+						ScheduledFuture<?> currentPending = pendingNameUpdate;
+						if (currentPending == null || currentPending.isDone()) {
+							currentPending = consoleNameUpdateExecutor.schedule(() -> {
+								pendingNameUpdate = null;
+								resetName(false);
+							}, 1, TimeUnit.SECONDS);
+						}
 						// pointless to update milliseconds:
 						elapsedFormat = "%d:%02d:%02d"; //$NON-NLS-1$
 					}
@@ -531,6 +547,7 @@ public IProcess getProcess() {
 	protected void dispose() {
 		super.dispose();
 		fColorProvider.disconnect();
+		consoleNameUpdateExecutor.shutdownNow();
 		DebugPlugin.getDefault().removeDebugEventListener(this);
 		DebugUIPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(this);
 		JFaceResources.getFontRegistry().removeListener(this);